-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binary export of surplus typedefinition #1576
Conversation
mregen
commented
Nov 3, 2021
- HasTypeDefinition and TypeDefinitionId should only exist for Object/Variable in .uanodes
- fix binary export for .uanodes
- Mc issue 94 #1574 missed the binary output case, only fixed xml export
- fixes The server library exposes some nodes with HasTypeDefinition reference to the same node. #1532
- fixes The Methods generated in Opc.Ua.PredefinedNodes contain TypeDefinition references UA-ModelCompiler#94
- fix the default and sample models in this repo
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
=======================================
Coverage 52.88% 52.89%
=======================================
Files 312 312
Lines 57316 57316
=======================================
+ Hits 30311 30316 +5
+ Misses 27005 27000 -5
Continue to review full report at Codecov.
|
Yes that is another way to fix. The fix equivalent to mine would have been in the Save method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #1532 looks to be fixed