Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary export of surplus typedefinition #1576

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Fix binary export of surplus typedefinition #1576

merged 2 commits into from
Nov 4, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Nov 3, 2021

@mregen
Copy link
Contributor Author

mregen commented Nov 3, 2021

@mrsuciu , could you check if #1532 is fixed now?

@mregen mregen modified the milestone: 1.4.367 Nov 3, 2021
@mregen mregen changed the title Fix binary export of type definition Fix binary export of surplus typedefinition Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1576 (f259f2a) into master (1e2b6e0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1576   +/-   ##
=======================================
  Coverage   52.88%   52.89%           
=======================================
  Files         312      312           
  Lines       57316    57316           
=======================================
+ Hits        30311    30316    +5     
+ Misses      27005    27000    -5     
Impacted Files Coverage Δ
...tack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Classes.cs 25.00% <ø> (ø)
Stack/Opc.Ua.Core/Stack/State/BaseInstanceState.cs 27.02% <0.00%> (ø)
Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs 72.51% <0.00%> (-1.17%) ⬇️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.15% <0.00%> (-0.40%) ⬇️
.../Opc.Ua.Server/Subscription/SubscriptionManager.cs 61.37% <0.00%> (-0.15%) ⬇️
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 60.73% <0.00%> (-0.11%) ⬇️
Libraries/Opc.Ua.Client/Session.cs 63.16% <0.00%> (+0.20%) ⬆️
Libraries/Opc.Ua.Client/Subscription.cs 70.31% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2b6e0...f259f2a. Read the comment docs.

@opcfoundation-org
Copy link
Contributor

Yes that is another way to fix. The fix equivalent to mine would have been in the Save method.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #1532 looks to be fixed

@mregen mregen merged commit 7acddc0 into master Nov 4, 2021
@mregen mregen deleted the mc-export branch November 4, 2021 07:37
mregen added a commit that referenced this pull request Nov 24, 2021
- the previous fix to remove TypeDefinitionId caused a regression with Alarms (#1574/#1576)
- This is a backward compatible fix to remove the TypeDefintionId where it is not needed in the nodeset but still fill the MethodDeclarationId.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants