-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge model compiler fixes with latest code. #1279
Conversation
This pull request introduces 1 alert and fixes 1 when merging 1305e94 into a2e8489 - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
===========================================
- Coverage 41.78% 30.94% -10.84%
===========================================
Files 289 290 +1
Lines 105003 105028 +25
===========================================
- Hits 43872 32506 -11366
- Misses 61131 72522 +11391
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging c22ecec into a2e8489 - view on LGTM.com fixed alerts:
|
This pull request introduces 1 alert and fixes 1 when merging e016a9b into a2e8489 - view on LGTM.com new alerts:
fixed alerts:
|
{ | ||
m_writer.Write("}"); | ||
} | ||
if (m_topLevelIsArray) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick-- formatting seems off, if you do a Ctrl-K D it formats the whole thing
Changes needed for model compiler.