Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge model compiler fixes with latest code. #1279

Merged
merged 3 commits into from
Feb 6, 2021

Conversation

opcfoundation-org
Copy link
Contributor

Changes needed for model compiler.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2021

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link

lgtm-com bot commented Feb 5, 2021

This pull request introduces 1 alert and fixes 1 when merging 1305e94 into a2e8489 - view on LGTM.com

new alerts:

  • 1 for Constant condition

fixed alerts:

  • 1 for Dereferenced variable may be null

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1279 (c22ecec) into master (a2e8489) will decrease coverage by 10.83%.
The diff coverage is 10.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1279       +/-   ##
===========================================
- Coverage   41.78%   30.94%   -10.84%     
===========================================
  Files         289      290        +1     
  Lines      105003   105028       +25     
===========================================
- Hits        43872    32506    -11366     
- Misses      61131    72522    +11391     
Impacted Files Coverage Δ
.../Opc.Ua.Core/Stack/State/ModelCompilerExtension.cs 0.00% <0.00%> (ø)
Stack/Opc.Ua.Core/Stack/State/NodeState.cs 34.90% <ø> (ø)
...ack/Opc.Ua.Core/Stack/State/NodeStateCollection.cs 42.41% <ø> (ø)
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 28.42% <5.12%> (-47.82%) ⬇️
Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs 26.59% <19.04%> (-50.38%) ⬇️
Stack/Opc.Ua.Core/Types/Schemas/BinarySchema.cs 0.00% <0.00%> (-100.00%) ⬇️
Stack/Opc.Ua.Core/Stack/Types/WriteValue.cs 2.27% <0.00%> (-77.28%) ⬇️
...c.Ua.Core/Stack/Types/MonitoredItemNotification.cs 0.00% <0.00%> (-75.00%) ⬇️
Stack/Opc.Ua.Core/Stack/Types/QueryDataSet.cs 0.00% <0.00%> (-66.67%) ⬇️
...Opc.Ua.Core/Types/Schemas/BinarySchemaValidator.cs 0.00% <0.00%> (-66.48%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e8489...e016a9b. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 5, 2021

This pull request fixes 1 alert when merging c22ecec into a2e8489 - view on LGTM.com

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Feb 5, 2021

This pull request introduces 1 alert and fixes 1 when merging e016a9b into a2e8489 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

{
m_writer.Write("}");
}
if (m_topLevelIsArray)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick-- formatting seems off, if you do a Ctrl-K D it formats the whole thing

@opcfoundation-org opcfoundation-org merged commit 4180fd8 into master Feb 6, 2021
@mregen mregen deleted the modelcompiler-fixes branch February 6, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants