Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement encoders support for Arrays and multi-dimensional Arrays. #1350

Merged
merged 5 commits into from
Apr 7, 2021

Conversation

AlinMoldovean
Copy link
Contributor

@AlinMoldovean AlinMoldovean commented Apr 2, 2021

@AlinMoldovean AlinMoldovean changed the title Implement encoders support Arrays and multi-dimensional Arrays. Implement encoders support for Arrays and multi-dimensional Arrays. Apr 2, 2021
@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2021

This pull request introduces 8 alerts and fixes 2 when merging 58bf1b9 into 1d5e87c - view on LGTM.com

new alerts:

  • 5 for Useless assignment to local variable
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2021

This pull request introduces 2 alerts and fixes 2 when merging cfba7ea into 1d5e87c - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2021

This pull request fixes 2 alerts when merging 36e4323 into 1d5e87c - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Dereferenced variable may be null

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great... how about few more cases with Json encoder test? How is code coverage for the new code?

Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs Outdated Show resolved Hide resolved
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs Outdated Show resolved Hide resolved
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs Outdated Show resolved Hide resolved
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs Outdated Show resolved Hide resolved
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs Outdated Show resolved Hide resolved
@AlinMoldovean
Copy link
Contributor Author

this is great... how about few more cases with Json encoder test? How is code coverage for the new code?

The added tests have coverage for new ReadArray()/WriteArray() methods.
Some more Json/BinaryEncoder tests are prepared in the upcoming PubSub update for MQTT.

@lgtm-com
Copy link

lgtm-com bot commented Apr 7, 2021

This pull request fixes 2 alerts when merging 36bb5bc into 1d5e87c - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Dereferenced variable may be null

@AlinMoldovean AlinMoldovean merged commit cb1abb1 into OPCFoundation:master Apr 7, 2021
@AlinMoldovean AlinMoldovean deleted the matrixEncoders branch April 20, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants