Port thread scheduler and servicehost from UA .NET legacy. #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RequestQueue class constructor the threadpool configuration has been added in order to handle the minThreadCount and maxThreadCount parameters. Those parameters are the ones coming from the server config .xml (MinRequestThreadCount, MaxRequestThreadCount) and at the moment are not handled in the code. This modification allows correct setting of the threadpool so that the server can work with the specified parameters, thus improving performances in a multiclient environment. Co-Authored-By: macheronte <79026457+macheronte@users.noreply.github.com>
|
|
In RequestQueue class constructor the threadpool configuration has been added in order to handle the minThreadCount and maxThreadCount parameters. Those parameters are the ones coming from the server config .xml (MinRequestThreadCount, MaxRequestThreadCount) and at the moment are not handled in the code. This modification allows correct setting of the threadpool so that the server can work with the specified parameters, thus improving performances in a multiclient environment. Co-Authored-By: macheronte <79026457+macheronte@users.noreply.github.com> Co-authored-by: Nyphus <83399280+Nyphus@users.noreply.github.com> Co-authored-by: macheronte <79026457+macheronte@users.noreply.github.com>
|
Hi @Nyphus I ported the .NET legacy thread scheduler back, it should provide better perf, please test if this fix is also a solution... |
mregen
changed the title
mregen
approved these changes
May 2, 2021
.editorconfig
Outdated
| # CA3075: Insecure DTD processing in XML | ||
| dotnet_diagnostic.CA3075.severity = warning | ||
|
|
||
| # RCS1090: Add call to 'ConfigureAwait' (or vice versa) | ||
| dotnet_diagnostic.RCS1090.severity = warning | ||
| dotnet_diagnostic.RCS1090.severity = silent |
There was a problem hiding this comment.
caused false warnings in winforms code, where ConfigureAwait cannot be used.
|
This pull request introduces 1 alert and fixes 4 when merging 782be8b into 7e736d2 - view on LGTM.com new alerts:
fixed alerts:
|
mregen
reviewed
May 4, 2021
mregen
reviewed
May 4, 2021
AlinMoldovean
approved these changes
May 4, 2021
| set { m_endpointDescription = value; } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// The types known to the server. | ||
| /// Returns the errr of the server. |
There was a problem hiding this comment.
typo - error instead of errr
mregen
reviewed
May 4, 2021
mregen
reviewed
May 4, 2021
|
This pull request introduces 1 alert and fixes 4 when merging 5111599 into 323c8c9 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RequestQueue class constructor the threadpool configuration has been added
in order to handle the minThreadCount and maxThreadCount parameters.
Those parameters are the ones coming from the server config .xml
(MinRequestThreadCount, MaxRequestThreadCount) and at the moment
are not handled in the code.
This modification allows correct setting of the threadpool so that the server can work
with the specified parameters, thus improving performances in a multiclient environment.
Co-Authored-By: macheronte 79026457+macheronte@users.noreply.github.com