Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode/Decode improvements for Array and Matrix #1398

Merged
merged 2 commits into from
May 12, 2021

Conversation

AlinMoldovean
Copy link
Contributor

  • Improve Encode/Decode of Array and Matrix for IEncodable according to specs.

Octavia Stan and others added 2 commits May 12, 2021 12:28
Add tests for encode/decode of array/matrix of all Iencodeable types loaded in Appdomain
@AlinMoldovean AlinMoldovean requested a review from mregen May 12, 2021 09:59
@lgtm-com
Copy link

lgtm-com bot commented May 12, 2021

This pull request introduces 2 alerts when merging 8a21337 into ab05d09 - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null


[Theory]
[Category("EncodableTypes")]
public void ActivateEncodableTypeArray(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great test!

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlinMoldovean AlinMoldovean merged commit 923597e into OPCFoundation:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants