Add a no file fluent API for application configuration. #1422
Conversation
|
This pull request introduces 2 alerts when merging 6b6a5c8 into 24f90c4 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 4839b72 into 24f90c4 - view on LGTM.com new alerts:
|
|
switch GDS tests turned out extensions are yet missing |
|
This pull request introduces 2 alerts when merging bf6b715 into 24f90c4 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 991b96f into 24f90c4 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 2ba7279 into 24f90c4 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 42615e2 into 24f90c4 - view on LGTM.com new alerts:
|
| var uri = SecurityPolicies.GetUri(name); | ||
| if (uri != null) | ||
| { | ||
| deprecatedPolicyList.Add(uri); |
There was a problem hiding this comment.
deprecatedPolicyList is not added to main list.
AddSecurityPolicies() is called internally only with deprecated = false
There was a problem hiding this comment.
yes, intentionally added a AddPolicy instead of allowing to add all deprecated policies. However the function might be useful for testing, so I keep it around for a bit,
There was a problem hiding this comment.
updated API design --> I removed addDeprecated in favor of AddPolicy, to avoid to make it too easy to have unsecure policy settings.
| ApplicationCertificate = new CertificateIdentifier() | ||
| { | ||
| StoreType = appStoreType, | ||
| StorePath = DefaultCertificateStorePath(TrustlistType.Application, pkiRoot), |
There was a problem hiding this comment.
should be appRoot here instead of pkiRoot, right?
StorePath = DefaultCertificateStorePath(TrustlistType.Application, appRoot),
There was a problem hiding this comment.
Indeed, good catch! Also if appRoot == null, the pkiRoot should be used
|
This pull request introduces 2 alerts when merging a6efd3d into 24f90c4 - view on LGTM.com new alerts:
|
No description provided.