Improve JsonDecoder StreamWriter dispose

[mregen]

• only dispose StreamWriter if owned by JsonEncoder
• only dispose if dispose is called
• on external stream writer, return text by using reflection on basestream, if memorystream is used
• fixes JSONEncoder should use Stream, support leaveOpen on close #1444

[koepalex]

Is this really necessary? m_writer?.Dispose() should internally dispose the memory stream

[mregen]

ok, I wasn't sure...

[codecov]

Codecov Report

Merging #1448 (45695af) into master (08164fe) will increase coverage by 0.01%.
The diff coverage is 84.48%.

❗ Current head 45695af differs from pull request most recent head 6c7a801. Consider uploading reports for the commit 6c7a801 to get more accurate results

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   51.61%   51.62%   +0.01%     
==========================================
  Files         305      305              
  Lines       58590    58598       +8     
==========================================
+ Hits        30239    30253      +14     
+ Misses      28351    28345       -6     

Impacted Files	Coverage Δ
...es/Opc.Ua.PubSub/Transport/MqttPubSubConnection.cs	27.96% <0.00%> (ø)
...ies/Opc.Ua.PubSub/Transport/UdpPubSubConnection.cs	27.95% <0.00%> (ø)
Libraries/Opc.Ua.PubSub/UaNetworkMessage.cs	80.00% <ø> (ø)
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs	79.74% <0.00%> (ø)
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs	83.51% <88.57%> (+0.32%)	⬆️
...aries/Opc.Ua.PubSub/Encoding/JsonNetworkMessage.cs	92.89% <100.00%> (-0.21%)	⬇️
...aries/Opc.Ua.PubSub/Encoding/UadpNetworkMessage.cs	87.58% <100.00%> (-0.09%)	⬇️
Libraries/Opc.Ua.PubSub/UaPubSubConnection.cs	45.19% <100.00%> (+0.53%)	⬆️
Stack/Opc.Ua.Core/Types/Encoders/BinaryEncoder.cs	78.00% <100.00%> (+0.04%)	⬆️
Stack/Opc.Ua.Core/Types/Encoders/XmlDecoder.cs	73.77% <100.00%> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08164fe...6c7a801. Read the comment docs.

[mregen]

After discussion:

• to not break existing code, let CloseXXX still dispose the writer
• add constructor with new signature to use stream and bool leaveOpen
• unify stream pattern across all encoders

[lgtm-com]

This pull request introduces 3 alerts when merging 2c88916 into b9ad021 - view on LGTM.com

new alerts:

• 3 for Useless assignment to local variable

[lgtm-com]

This pull request introduces 3 alerts and fixes 2 when merging 05ab8a5 into b9ad021 - view on LGTM.com

new alerts:

• 3 for Useless assignment to local variable

fixed alerts:

• 2 for Missing Dispose call on local IDisposable

[lgtm-com]

This pull request introduces 3 alerts and fixes 2 when merging e3d8c33 into 08164fe - view on LGTM.com

new alerts:

• 3 for Useless assignment to local variable

fixed alerts:

• 2 for Missing Dispose call on local IDisposable

[lgtm-com]

This pull request introduces 3 alerts and fixes 2 when merging 45695af into 08164fe - view on LGTM.com

new alerts:

• 3 for Useless assignment to local variable

fixed alerts:

• 2 for Missing Dispose call on local IDisposable

[lgtm-com]

This pull request introduces 3 alerts and fixes 2 when merging 6c7a801 into 08164fe - view on LGTM.com

new alerts:

• 3 for Useless assignment to local variable

fixed alerts:

• 2 for Missing Dispose call on local IDisposable