Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support supplied keys and RSACng for the cert generator #1507

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Sep 10, 2021

  • Allow to call SetRSAPublicKey without Issuer being set
  • Support to create self signed CA cert with supplied keys
  • Test case for RSACng on .NET framework

Issue reported by @eoursel

@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2021

This pull request introduces 1 alert when merging dfb287c into 76afe82 - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2021

This pull request introduces 1 alert when merging f2d9289 into 76afe82 - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2021

This pull request introduces 1 alert when merging 7a85bcc into 76afe82 - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #1507 (7a85bcc) into master (76afe82) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
+ Coverage   51.93%   51.95%   +0.02%     
==========================================
  Files         307      307              
  Lines       58332    58334       +2     
==========================================
+ Hits        30292    30305      +13     
+ Misses      28040    28029      -11     
Impacted Files Coverage Δ
...Certificates/X509Certificate/CertificateBuilder.cs 83.70% <100.00%> (+0.18%) ⬆️
...braries/Opc.Ua.Server/Subscription/Subscription.cs 54.48% <0.00%> (+0.11%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 43.78% <0.00%> (+0.30%) ⬆️
Libraries/Opc.Ua.Client/Session.cs 61.04% <0.00%> (+0.36%) ⬆️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.54% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76afe82...7a85bcc. Read the comment docs.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@mregen mregen merged commit a677141 into master Sep 13, 2021
@mregen mregen deleted the suppliedkeys branch September 13, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants