Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to validate client publish request count #1516

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Test to validate client publish request count #1516

merged 4 commits into from
Sep 21, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Sep 16, 2021

fixes #1455
Test validates that client handles the BadTooManyPublishrequest properly and lowers number of active requests if necessary.

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2021

This pull request introduces 1 alert when merging cedb6bf into 92ae1d3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1516 (b5a2157) into master (92ae1d3) will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   52.17%   52.87%   +0.69%     
==========================================
  Files         307      307              
  Lines       58370    58489     +119     
==========================================
+ Hits        30455    30925     +470     
+ Misses      27915    27564     -351     
Impacted Files Coverage Δ
Libraries/Opc.Ua.Client/Session.cs 61.56% <0.00%> (-1.09%) ⬇️
Libraries/Opc.Ua.Client/Subscription.cs 69.58% <0.00%> (-0.73%) ⬇️
Stack/Opc.Ua.Core/Stack/State/NodeState.cs 39.10% <0.00%> (+0.20%) ⬆️
...braries/Opc.Ua.Server/Subscription/Subscription.cs 56.64% <0.00%> (+0.22%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 44.39% <0.00%> (+0.30%) ⬆️
Stack/Opc.Ua.Core/Stack/Tcp/TcpMessageSocket.cs 73.72% <0.00%> (+0.34%) ⬆️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.54% <0.00%> (+0.39%) ⬆️
...ack/Opc.Ua.Core/Stack/Tcp/ChannelAsyncOperation.cs 68.75% <0.00%> (+1.04%) ⬆️
Stack/Opc.Ua.Core/Stack/State/NodeBrowser.cs 78.04% <0.00%> (+1.21%) ⬆️
Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.cs 69.36% <0.00%> (+1.70%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ae1d3...b5a2157. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2021

This pull request introduces 1 alert when merging 9995d2a into 5048189 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request introduces 1 alert when merging bdfe340 into 5048189 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@mregen
Copy link
Contributor Author

mregen commented Sep 17, 2021

The SequentialPublishing Test is still a bit flaky...

@mregen mregen marked this pull request as draft September 20, 2021 06:30
@mregen
Copy link
Contributor Author

mregen commented Sep 20, 2021

Reinvestigate the flaky test cases...

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2021

This pull request introduces 1 alert when merging b5a2157 into 7d310d5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@mregen mregen marked this pull request as ready for review September 21, 2021 04:48
@mregen mregen merged commit 0d34b7d into master Sep 21, 2021
@mregen mregen deleted the publishrequest branch September 21, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BadTooManyPublishRequests is not properly handled by client SDK
3 participants