Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodeSet import/export of ArrayDimensions in StructureField #1115 #1517

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

cristipogacean
Copy link
Contributor

Fix NodeSet import/export of ArrayDimensions in StructureField #1115

@cristipogacean cristipogacean self-assigned this Sep 16, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2021

This pull request introduces 4 alerts when merging c20121e into 5048189 - view on LGTM.com

new alerts:

  • 4 for Dereferenced variable may be null

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1517 (c20121e) into master (2b54136) will increase coverage by 1.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
+ Coverage   51.95%   53.22%   +1.27%     
==========================================
  Files         307      307              
  Lines       58323    58927     +604     
==========================================
+ Hits        30302    31365    +1063     
+ Misses      28021    27562     -459     
Impacted Files Coverage Δ
Stack/Opc.Ua.Core/Schema/UANodeSetHelpers.cs 46.20% <100.00%> (+46.20%) ⬆️
...ack/Opc.Ua.Core/Stack/Transport/AsyncResultBase.cs 61.61% <0.00%> (-5.06%) ⬇️
...indings.Https/Stack/Https/HttpsTransportChannel.cs 66.21% <0.00%> (-3.38%) ⬇️
Stack/Opc.Ua.Core/Types/BuiltIn/DiagnosticInfo.cs 60.00% <0.00%> (-1.38%) ⬇️
Libraries/Opc.Ua.Server/Session/SessionManager.cs 71.37% <0.00%> (-1.04%) ⬇️
Stack/Opc.Ua.Core/Types/Utils/ServiceResult.cs 69.15% <0.00%> (-0.94%) ⬇️
Libraries/Opc.Ua.Client/SubscriptionAsync.cs 63.69% <0.00%> (-0.42%) ⬇️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.15% <0.00%> (-0.40%) ⬇️
.../Opc.Ua.Server/Subscription/SubscriptionManager.cs 61.37% <0.00%> (+0.14%) ⬆️
Stack/Opc.Ua.Core/Stack/State/NodeState.cs 39.10% <0.00%> (+0.27%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b54136...c20121e. Read the comment docs.

@mregen
Copy link
Contributor

mregen commented Sep 17, 2021

@cristipogacean nice ! + Coverage 51.95% 53.22% +1.27%

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however this may affect ModelCompiler output, lets check with @randy-armstrong .

@mregen mregen merged commit 7d310d5 into master Sep 20, 2021
@mregen mregen deleted the fix/nodeset2exportdimensions branch September 20, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayDimensions of StructureField are not written to xml when exporting NodeSet
3 participants