-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application config improvements for cert recreation #1525
Conversation
This pull request introduces 2 alerts when merging d137a84 into 33ae8bb - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging ede6459 into 33ae8bb - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging d4765b1 into 33ae8bb - view on LGTM.com new alerts:
|
message.AppendLine("Loading a certificate with private key from the directory store."); | ||
message.AppendLine("Ensure to call LoadPrivateKeyEx with password provider before calling Find(true)."); | ||
Utils.Trace(Utils.TraceMasks.Error, message.ToString()); | ||
Debug.Assert(!needPrivateKey, message.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove debug assert...
Codecov Report
@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
+ Coverage 52.96% 52.99% +0.03%
==========================================
Files 308 317 +9
Lines 58395 60329 +1934
==========================================
+ Hits 30928 31974 +1046
- Misses 27467 28355 +888
Continue to review full report at Codecov.
|
This pull request introduces 4 alerts when merging ea5cd21 into 33ae8bb - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces 2 alerts when merging 531f112 into 75744e2 - view on LGTM.com new alerts:
|
fixes Prevent false use of loading the application certificate, causing 'Keyset not valid' error. (Windows) #1162 , fixes ApplicationInstance.CheckApplicationInstanceCertificate side effect #1102