IOP workshop fixes and build improvements #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: testing .NET5.0 build, will be removed |
|
This pull request introduces 1 alert when merging 373e332 into ed434e9 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 5212cfc into ed434e9 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging fb74d65 into ed434e9 - view on LGTM.com new alerts:
|
|
as a sidenote the .NET5.0 build is passing, but the .NET 4.7.2 build is missing some functionality (ImportSubjectPublicKeyInfo) to be able to fully support the ECC and RSA cert functions. The .NET5 and net472 build steps have been removed for this PR. |
opcfoundation-org
pushed a commit
that referenced
this pull request
Nov 2, 2021
-fixes for complex types: - a structure which contains an enum from namespace 0 can not be created. fixes #1561. - a structure with multidimensional array may lead to a endless loop in `ComplexTypeSystem.Load` - a malformed namespace Uri which contains a space character prevents creation of type system. - select endpoint doesn't pick the right scheme if the default endpoint must be picked -prep for net472 or greater and net5.0 or greater build, only build #ifdef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-prep for net472 or greater and net5.0 or greater build, only build #ifdef
-fixes for complex types:
ComplexTypeSystem.Load