Implement a common method for creating branches #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic updating of Retain
|
This pull request introduces 2 alerts when merging 11e458a into 31e4a2b - view on LGTM.com new alerts:
|
mregen
reviewed
Nov 22, 2021
There was a problem hiding this comment.
Hi @Archie-Miller , technically this is an API update so we may have to wait for the next version (aka.368, no worries, we switch likely very soon)
second, is there sample code how to use this? Even better were a alarm namespace in the ref sample server and/or test cases. There are now client/server fixtures.
| /// <returns></returns> | ||
| public Dictionary< string, ConditionState >GetBranches() | ||
| { | ||
| if (m_branches == null) |
There was a problem hiding this comment.
makes me wonder if the access to the Dictionary needsto be synchronized?
There was a problem hiding this comment.
I'm not sure of the reason why this might be necessary, but I'm ready to discuss your concerns!
mregen
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a mechanism to create Alarm Branches, store them, allow AddComment, Acknowledge, and Confirm them.
Updates the Retain flag automatically.
Cleans up branches on Ack/Confirm
Allows servers to retrieve branches to clear them all if necessary.