Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Roslynator checks in CI build #1608

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Enforce Roslynator checks in CI build #1608

merged 1 commit into from
Nov 24, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Nov 24, 2021

  • The ci pass includes Roslynator checks, fails on warnings
  • Fix all existing warnings

@lgtm-com
Copy link

lgtm-com bot commented Nov 24, 2021

This pull request fixes 2 alerts when merging 24e0b55 into 486e97b - view on LGTM.com

fixed alerts:

  • 2 for Constant condition

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1608 (24e0b55) into master (31e4a2b) will increase coverage by 0.07%.
The diff coverage is 3.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
+ Coverage   53.41%   53.49%   +0.07%     
==========================================
  Files         312      312              
  Lines       57364    57364              
==========================================
+ Hits        30640    30685      +45     
+ Misses      26724    26679      -45     
Impacted Files Coverage Δ
....PubSub/Configuration/ConfigurationVersionUtils.cs 5.26% <ø> (ø)
...aries/Opc.Ua.PubSub/Transport/MqttClientCreator.cs 0.00% <0.00%> (ø)
Libraries/Opc.Ua.PubSub/Transport/UdpDiscovery.cs 0.00% <0.00%> (ø)
...s/Opc.Ua.PubSub/Transport/UdpDiscoveryPublisher.cs 0.00% <0.00%> (ø)
.../Opc.Ua.PubSub/Transport/UdpDiscoverySubscriber.cs 0.00% <0.00%> (ø)
...ies/Opc.Ua.PubSub/Transport/UdpPubSubConnection.cs 30.00% <0.00%> (ø)
Stack/Opc.Ua.Core/Stack/Nodes/ContentFilter.cs 5.27% <0.00%> (ø)
.../Opc.Ua.Core/Stack/Types/ContentFilter.Evaluate.cs 0.00% <0.00%> (ø)
...raries/Opc.Ua.PubSub/Transport/UdpClientCreator.cs 7.77% <33.33%> (+0.16%) ⬆️
...urity.Certificates/X509Certificate/X509PfxUtils.cs 69.87% <75.00%> (-0.50%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e4a2b...24e0b55. Read the comment docs.

@mregen mregen requested a review from mrsuciu November 24, 2021 10:59
@mregen mregen merged commit 2430a65 into master Nov 24, 2021
@mregen mregen deleted the rcs branch November 24, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants