-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BitwiseAnd and BitwiseOr filter operators and unit tests for existing filter operators #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd and BitwiseOr operators to return boolean values or null
mregen
reviewed
Dec 13, 2021
mregen
reviewed
Dec 13, 2021
Tests/Opc.Ua.Core.Tests/Types/ContentFillter/ContentFilterTests.cs
Outdated
Show resolved
Hide resolved
mregen
requested changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe one more small issue and typo..
Tests/Opc.Ua.Core.Tests/Types/ContentFillter/ContentFilterTests.cs
Outdated
Show resolved
Hide resolved
mregen
reviewed
Dec 14, 2021
Tests/Opc.Ua.Core.Tests/Types/ContentFillter/ContentFilterTests.cs
Outdated
Show resolved
Hide resolved
…nder the ContentFilterElement.Validate and ContentFilterElement.ToString methods
…d adapted unit tests
mregen
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Ready? |
fixes #1178 |
mrsuciu
added a commit
to mrsuciu/UA-.NETStandard
that referenced
this pull request
Jan 20, 2022
…isting filter operators (OPCFoundation#1633) * Added BitwiseAnd and BitwiseOr filter operators * Added positive unit tests for filter operators; Changed Cast BitwiseAnd and BitwiseOr operators to return boolean values or null * BitwiseAnd and BitwiseOr return the operation value; Improved unit tests * Added missing handling of BitwiseAnd and BitwiseOr filter operators under the ContentFilterElement.Validate and ContentFilterElement.ToString methods * Changed Cast operator to return value instead of bool; Fixed typos and adapted unit tests
mregen
added a commit
that referenced
this pull request
Jan 20, 2022
* Fix Authority Key Identifier in SubCA and cert validator return codes. (#1665) * Fix: Server endpoints are not returned if GetHostEntry fails. (#1639) * Added BitwiseAnd and BitwiseOr filter operators and unit tests for existing filter operators (#1633) * Fix Authority Key Identifier for Bouncy Castle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BitwiseAnd and BitwiseOr filter operators and unit tests for existing filter operators