Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BitwiseAnd and BitwiseOr filter operators and unit tests for existing filter operators #1633

Merged
merged 5 commits into from
Dec 15, 2021

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Dec 10, 2021

Added BitwiseAnd and BitwiseOr filter operators and unit tests for existing filter operators

@mregen mregen added this to the 1.4.368 milestone Dec 11, 2021
@mrsuciu mrsuciu marked this pull request as draft December 13, 2021 13:40
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe one more small issue and typo..

…nder the ContentFilterElement.Validate and ContentFilterElement.ToString methods
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 :shipit:

@mregen
Copy link
Contributor

mregen commented Dec 15, 2021

Ready?

@mrsuciu mrsuciu marked this pull request as ready for review December 15, 2021 13:44
@mrsuciu mrsuciu merged commit b55ef38 into OPCFoundation:master Dec 15, 2021
@mregen
Copy link
Contributor

mregen commented Dec 17, 2021

fixes #1178

mrsuciu added a commit to mrsuciu/UA-.NETStandard that referenced this pull request Jan 20, 2022
…isting filter operators (OPCFoundation#1633)

* Added BitwiseAnd and BitwiseOr filter operators

* Added positive unit tests for filter operators; Changed Cast BitwiseAnd and BitwiseOr operators to return boolean values or null

* BitwiseAnd and BitwiseOr return the operation value; Improved unit tests

* Added missing handling of BitwiseAnd and BitwiseOr filter operators under the ContentFilterElement.Validate and ContentFilterElement.ToString methods

* Changed Cast operator to return value instead of bool; Fixed typos and adapted unit tests
mregen added a commit that referenced this pull request Jan 20, 2022
* Fix Authority Key Identifier in SubCA and cert validator return codes. (#1665)
* Fix: Server endpoints are not returned if GetHostEntry fails. (#1639)
* Added BitwiseAnd and BitwiseOr filter operators and unit tests for existing filter operators  (#1633)
* Fix Authority Key Identifier for Bouncy Castle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants