Fix Authority Key Identifier in SubCA and cert validator return codes. #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mregen
commented
Jan 14, 2022
mregen
commented
- AuthorityKeyIdentifier in the SubCA contains the SubjectName of the Issuer instead of the IssuerName. Also an application certificate that is signed by a SubCA would contain the false information.
- The false information has no effect on Windows and macOS, however on linux OpenSSL tests all fields and a chain cannot be fully validated.
- For CTT tests a few error codes were false returned because ServiceResult replaces the error code with the InnerException.
- Do not allow to ignore PartialChain validation error, it may have different root cause then the error returned by GetIssuer.
mrsuciu
approved these changes
Jan 14, 2022
mrsuciu
pushed a commit
to mrsuciu/UA-.NETStandard
that referenced
this pull request
Jan 20, 2022
OPCFoundation#1665) - AuthorityKeyIdentifier in the SubCA contains the SubjectName of the Issuer instead of the IssuerName. Also an application certificate that is signed by a SubCA would contain the false information. - The false information has no effect on Windows and macOS, however on linux OpenSSL tests all fields and a chain cannot be fully validated. - For CTT tests a few error codes were return false codes because ServiceResult replaces the error code with the InnerException error. - Do not allow to ignore PartialChain validation error, it may have different root cause then the error returned by GetIssuer.
mregen
added a commit
that referenced
this pull request
Jan 20, 2022
* Fix Authority Key Identifier in SubCA and cert validator return codes. (#1665) * Fix: Server endpoints are not returned if GetHostEntry fails. (#1639) * Added BitwiseAnd and BitwiseOr filter operators and unit tests for existing filter operators (#1633) * Fix Authority Key Identifier for Bouncy Castle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.