Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS2017 build issue with Roslynator #1641

Merged
merged 6 commits into from
Dec 17, 2021
Merged

Fix VS2017 build issue with Roslynator #1641

merged 6 commits into from
Dec 17, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Dec 16, 2021

  • vs2017 now only supports .NET 4.6.2 builds, .NET Core 2.1 is end of life.
  • Roslynator was not properly excluded in VS2017, change the condition to
  • fixes Cannot start reference client in Visual studio 2017 #1630
  • fix a few lgtm warnings
  • fix a few license headers (everything outside of \Stack is MIT)
  • fix flaky Hiresclock test.

@mregen mregen mentioned this pull request Dec 16, 2021
5 tasks
@mregen mregen linked an issue Dec 16, 2021 that may be closed by this pull request
5 tasks
@mregen mregen requested a review from mrsuciu December 16, 2021 12:53
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1641 (5ec231b) into master (a147eb5) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 5ec231b differs from pull request most recent head 180c65a. Consider uploading reports for the commit 180c65a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
+ Coverage   53.71%   53.78%   +0.06%     
==========================================
  Files         319      319              
  Lines       57733    57733              
==========================================
+ Hits        31011    31050      +39     
+ Misses      26722    26683      -39     
Impacted Files Coverage Δ
Libraries/Opc.Ua.Client/OpcUaClientEventSource.cs 55.00% <ø> (ø)
...urity.Certificates/X509Certificate/X509PfxUtils.cs 69.87% <ø> (ø)
...ies/Opc.Ua.Server/Server/OpcUaServerEventSource.cs 46.93% <ø> (ø)
Stack/Opc.Ua.Core/Stack/State/NodeState.cs 42.80% <ø> (ø)
.../Opc.Ua.Server/Subscription/SubscriptionManager.cs 61.34% <0.00%> (+0.14%) ⬆️
.../Opc.Ua.Server/Subscription/SessionPublishQueue.cs 62.69% <0.00%> (+0.31%) ⬆️
Stack/Opc.Ua.Core/Stack/Tcp/TcpMessageSocket.cs 73.72% <0.00%> (+0.34%) ⬆️
...ack/Opc.Ua.Core/Stack/Tcp/ChannelAsyncOperation.cs 68.75% <0.00%> (+1.04%) ⬆️
Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs 71.15% <0.00%> (+1.28%) ⬆️
Libraries/Opc.Ua.Client/Session.cs 64.40% <0.00%> (+1.50%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a147eb5...180c65a. Read the comment docs.

@mregen mregen linked an issue Dec 17, 2021 that may be closed by this pull request
5 tasks
Copy link
Contributor Author

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lgtm-com
Copy link

lgtm-com bot commented Dec 17, 2021

This pull request fixes 6 alerts when merging 180c65a into a147eb5 - view on LGTM.com

fixed alerts:

  • 3 for Container contents are never accessed
  • 2 for Useless assignment to local variable
  • 1 for Invalid string formatting

@mregen mregen merged commit 7ae5c11 into master Dec 17, 2021
@mregen mregen deleted the vs2017 branch December 17, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants