-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VS2017 build issue with Roslynator #1641
Conversation
mregen
commented
Dec 16, 2021
•
edited
edited
- vs2017 now only supports .NET 4.6.2 builds, .NET Core 2.1 is end of life.
- Roslynator was not properly excluded in VS2017, change the condition to
- fixes Cannot start reference client in Visual studio 2017 #1630
- fix a few lgtm warnings
- fix a few license headers (everything outside of \Stack is MIT)
- fix flaky Hiresclock test.
This reverts commit 1043d30.
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
+ Coverage 53.71% 53.78% +0.06%
==========================================
Files 319 319
Lines 57733 57733
==========================================
+ Hits 31011 31050 +39
+ Misses 26722 26683 -39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request fixes 6 alerts when merging 180c65a into a147eb5 - view on LGTM.com fixed alerts:
|