Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Transfersubscription service #1649

Merged
merged 81 commits into from
Jan 28, 2022
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Dec 28, 2021

  • Implement client and server side of Transfersubscription service calls.
  • New Transcription service has been tested with CTT 1.04.9.398
  • Unit tests for native service calls and client SDK
  • Client implements multiple ways to transfer sessions:
    • Client saves subscriptions to xml stream, restarts, loads subscriptions from stream and transfers on server.
    • Client creates a new sessions and transfers into new session, while the old session is still active.
    • Client closes old session with DeleteSubscriptionsOnClose = false, creates new session and transfers subscriptions to new session.
    • SessionReconnectHandler tries to transfer subscription before recreating the subscriptions.

mregen and others added 30 commits November 24, 2021 12:13
we can't discard all parameter from local lambda (LanguageVersion 9 would be required, but only 7.3 is useable)
@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2022

This pull request introduces 3 alerts and fixes 1 when merging 2b6fc0d into 33ae736 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Use of default ToString()

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 3 alerts and fixes 1 when merging 1c2d1d7 into 8d3e393 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Use of default ToString()

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 3 alerts and fixes 1 when merging b952888 into 8d3e393 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Use of default ToString()

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 2 alerts and fixes 1 when merging bd5acbc into 8d3e393 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 2 alerts and fixes 1 when merging 6a5340c into 8d3e393 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 2 alerts and fixes 1 when merging d5d82cf into 8d3e393 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

@mregen mregen marked this pull request as ready for review January 25, 2022 20:52
@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 2 alerts and fixes 1 when merging bd66601 into 8d3e393 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

@mregen mregen changed the title [WIP] Implement Transfersubscription service Implement Transfersubscription service Jan 26, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2022

This pull request introduces 2 alerts and fixes 1 when merging b75d714 into 8d3e393 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2022

This pull request introduces 2 alerts and fixes 1 when merging 3cc7b30 into 8d3e393 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Jan 27, 2022

This pull request introduces 2 alerts and fixes 1 when merging 1998f48 into 079148f - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Dereferenced variable may be null

@mregen mregen merged commit 430ff70 into OPCFoundation:master Jan 28, 2022
@mregen mregen deleted the transfer branch January 31, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants