Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvements and minor cleanup / uncritical bug fixes #1650

Merged
merged 12 commits into from
Dec 30, 2021
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Dec 28, 2021

  • smaller API changes for .368 and minor cleanup / uncritical bug fixes
  • refactor GDS server lib to get rid of UA configuration dependency
  • app config builder enhancements to simplify someuse cases
    -- add a few default parameter to simplify fluent API
    -- Rejected folder doesn't default to pki root
    -- if the leaf pki folder is already provided, the default leaf folder is stil added (e.g. becomes own/own)
  • certificate validator match were to return true even if no keyId/serial number was checked
  • Directory store delete cert add retry if cert is still in use.
  • enable reverse connect tests on macOS
  • fixes CVE-2020-1045 (High) detected in microsoft.aspnetcore.http.2.1.1.nupkg mregen/UA-.NetStandardLibrary#114

@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2021

This pull request fixes 3 alerts when merging 4ef1066 into 0011f48 - view on LGTM.com

fixed alerts:

  • 2 for Call to obsolete method
  • 1 for Dereferenced variable may be null

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #1650 (7255a1d) into master (0011f48) will increase coverage by 0.05%.
The diff coverage is 81.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
+ Coverage   53.67%   53.73%   +0.05%     
==========================================
  Files         319      319              
  Lines       57744    57772      +28     
==========================================
+ Hits        30996    31044      +48     
+ Misses      26748    26728      -20     
Impacted Files Coverage Δ
...raries/Opc.Ua.Security.Certificates/Common/Oids.cs 43.47% <ø> (ø)
...Core/Security/Certificates/X509CertificateStore.cs 72.60% <ø> (ø)
...pc.Ua.Core/Security/Constants/SecurityConstants.cs 100.00% <ø> (ø)
Stack/Opc.Ua.Core/Types/Utils/LoggerUtils.cs 63.02% <ø> (ø)
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 82.32% <25.00%> (-0.24%) ⬇️
...ack/Opc.Ua.Core/Schema/ApplicationConfiguration.cs 62.10% <33.33%> (+0.09%) ⬆️
...pc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs 71.50% <53.84%> (ø)
...indings.Https/Stack/Https/HttpsTransportChannel.cs 68.45% <66.66%> (ø)
...a.Gds.Client.Common/GlobalDiscoveryServerClient.cs 73.50% <71.42%> (ø)
...Security/Certificates/DirectoryCertificateStore.cs 88.53% <81.81%> (-1.24%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0011f48...7255a1d. Read the comment docs.

@mregen mregen requested a review from mrsuciu December 29, 2021 06:40
reverse use_file_config for better codecov
@mregen mregen added this to the 1.4.368 milestone Dec 29, 2021
@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2021

This pull request fixes 3 alerts when merging 187c5fc into 0011f48 - view on LGTM.com

fixed alerts:

  • 2 for Call to obsolete method
  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2021

This pull request fixes 3 alerts when merging cffe40d into fe7c56f - view on LGTM.com

fixed alerts:

  • 2 for Call to obsolete method
  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2021

This pull request fixes 3 alerts when merging 7255a1d into fe7c56f - view on LGTM.com

fixed alerts:

  • 2 for Call to obsolete method
  • 1 for Dereferenced variable may be null

@mrsuciu mrsuciu merged commit 74af8ca into master Dec 30, 2021
@mregen mregen deleted the depnetcore2 branch December 31, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2020-1045 (High) detected in microsoft.aspnetcore.http.2.1.1.nupkg
2 participants