Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref server fixes for CTT #1685

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Ref server fixes for CTT #1685

merged 1 commit into from
Jan 27, 2022

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Jan 26, 2022

  • remove the SetDurableSubscription method, to skip the test cases
  • DeleteSubscription returns BadSubscriptionIdInvalid
  • MethodState return also BadTooManyArguments
  • return AttributeIdInvalid for null attributes (fix UA Expert display)
  • fix ToString of Variant array of ByteString
  • fix Variant decoding 1-dim array of bytestring

@mregen mregen requested a review from mrsuciu January 26, 2022 15:43
@codecov
Copy link

codecov bot commented Jan 26, 2022 •
edited

Codecov Report

Merging #1685 (cc1d5fb) into master (8d3e393) will decrease coverage by 0.13%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
- Coverage   53.91%   53.77%   -0.14%     
==========================================
  Files         319      319              
  Lines       58059    58086      +27     
==========================================
- Hits        31300    31234      -66     
- Misses      26759    26852      +93
Impacted Files Coverage Δ
.../Opc.Ua.Server/Subscription/SubscriptionManager.cs 61.04% <0.00%> (-0.30%) ⬇️
Stack/Opc.Ua.Core/Stack/State/MethodState.cs 61.65% <66.66%> (-0.12%) ⬇️
Stack/Opc.Ua.Core/Stack/State/NodeState.cs 42.85% <83.33%> (+0.04%) ⬆️
...pc.Ua.Server/Diagnostics/DiagnosticsNodeManager.cs 61.31% <100.00%> (+0.58%) ⬆️
Stack/Opc.Ua.Core/Types/BuiltIn/Variant.cs 64.09% <100.00%> (+0.70%) ⬆️
Stack/Opc.Ua.Core/Types/Encoders/BinaryDecoder.cs 79.01% <100.00%> (ø)
...ack/Opc.Ua.Core/Stack/Transport/AsyncResultBase.cs 61.61% <0.00%> (-5.06%) ⬇️
...indings.Https/Stack/Https/HttpsTransportChannel.cs 68.45% <0.00%> (-3.36%) ⬇️
Libraries/Opc.Ua.Client/Session.cs 62.02% <0.00%> (-3.01%) ⬇️
Stack/Opc.Ua.Core/Types/BuiltIn/DiagnosticInfo.cs 60.00% <0.00%> (-1.38%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3e393...cc1d5fb. Read the comment docs.

@mrsuciu mrsuciu merged commit 079148f into master Jan 27, 2022
mrsuciu pushed a commit to mrsuciu/UA-.NETStandard that referenced this pull request Jan 27, 2022
@mregen @mrsuciu
ctt fixes (OPCFoundation#1685)
ac13151 
* remove the SetDurableSubscription method, to skip the test cases
* DeleteSubscription returns BadSubscriptionIdInvalid
* MethodState return also BadTooManyArguments
* return AttributeIdInvalid for null attributes (fix UA Expert display)
* fix ToString of Variant array of ByteString
* fix Variant decoding 1-dim array of bytestring
mrsuciu added a commit that referenced this pull request Jan 27, 2022
@mrsuciu
Merge pull request #1684 from mrsuciu/1.4.367roleset
cc7fded 
Initialize well known nodes to default values
ctt fixes (#1685) 
Assign a default value to any variable in namespace 0
Set status code Good for all BaseVariableState in namespace 0
@mregen mregen deleted the cttfixes branch January 28, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsuciu mrsuciu mrsuciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mregen @mrsuciu