Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize well known nodes to default values #1684

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Jan 26, 2022

Initialize well known nodes to default values

mrsuciu and others added 2 commits January 27, 2022 11:28
* remove the SetDurableSubscription method, to skip the test cases
* DeleteSubscription returns BadSubscriptionIdInvalid
* MethodState return also BadTooManyArguments
* return AttributeIdInvalid for null attributes (fix UA Expert display)
* fix ToString of Variant array of ByteString
* fix Variant decoding 1-dim array of bytestring
@lgtm-com
Copy link

lgtm-com bot commented Jan 27, 2022

This pull request introduces 474 alerts and fixes 13 when merging f9a6509 into 03c9936 - view on LGTM.com

new alerts:

  • 471 for Use of default ToString()
  • 3 for Useless assignment to local variable

fixed alerts:

  • 11 for Missing Dispose call on local IDisposable
  • 2 for Dereferenced variable may be null

@mrsuciu mrsuciu merged commit cc7fded into OPCFoundation:release/1.4.367 Jan 27, 2022
@mrsuciu mrsuciu deleted the 1.4.367roleset branch January 27, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants