-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes an issue in Session.LoadDataTypeSystem. #2166
Conversation
Starting with line 1857 a dictionary of namespaces is populated in an defensive manner. If a namespace value can't be read, it is silently ignored. If this happens, it will result in an KeyNotFoundException when populating the imports dictionary. This fix adds a warning if a namespace value can't be read and populates the imports dictionary also defensivly.
Codecov Report
@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
- Coverage 57.90% 55.85% -2.05%
==========================================
Files 324 306 -18
Lines 61826 59234 -2592
==========================================
- Hits 35801 33086 -2715
- Misses 26025 26148 +123
|
probably flaky build... |
Thank you There is one issue open, code coverage. I have no idea how to write a unit test to test this. Looking at the coverage I see that error-pathes are often not covered ... |
Thanks, code coverage is sometimes also flaky and not blocking... |
Ok, so am I ready? - it's my first PR in this repo one last question: Should I do the same for the 1.5 branch or is there some internal process for this? |
Hi @AndreasHeisel , thanks for the fix! The 1.5 branch is only updated from time to time until it could be certified it remains in beta state. |
Starting with line 1857 a dictionary of namespaces is populated in an defensive manner. If a namespace value can't be read, it is silently ignored. If this happens, it will result in an KeyNotFoundException when populating the imports dictionary. This fix adds a warning if a namespace value can't be read and populates the imports dictionary also defensivly.
Proposed changes
Starting with line 1857 a dictionary of namespaces is populated in an defensive manner. If a namespace value can't be read, it is silently ignored. If this happens, it will result in a KeyNotFoundException when populating the imports dictionary. This fix adds a warning if a namespace value can't be read and populates the imports dictionary also defensivly.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
We noticed the problem when communicating with a server that hat a namespace value wich was not of type string.