Support .netstandard2.0 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SendAsync and ReceiveAsync now frequently return synchronously even if successful. These cases had not been properly handled yet, previous versions never hit these codepaths.
Integrate a library only build
|
Need to run a CTT pass on .NetStandard 2.0 ref server while we are waiting for CTT certification... |
AlinMoldovean
approved these changes
Sep 6, 2017
barnstee
reviewed
Sep 7, 2017
| @@ -1,7 +1,8 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netstandard1.4</TargetFramework> | |||
| <TargetFrameworks>net46;netstandard1.4;netstandard2.0</TargetFrameworks> | |||
| <DefineConstants Condition="'$(TargetFramework)' == 'netstandard2.0'">$(DefineConstants);NO_HTTPS</DefineConstants> | |||
There was a problem hiding this comment.
Why turn off HTTPS support for .Net Standard 2.0?
There was a problem hiding this comment.
Kestrel 2.0 doesn't compile yet. HTTPS is an extra work item for .Net Standard 2.0
tested with Ua Expert against standard and ref server
barnstee
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fix a bug in the TCP channel when .NetStandard2.0 uses synchronous return from SendAsync/ReceiveAsync, these cases were not properly handled and never called complete.
-build related fixes to support net46/uap/netstandard1.4 in one tbd nuget packet
-fix appveyor/travis builds