-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a limit to the Channels on the server side and removed "stale" channels #2540
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
- Coverage 54.70% 54.58% -0.13%
==========================================
Files 342 342
Lines 65041 65082 +41
Branches 13331 13350 +19
==========================================
- Hits 35581 35522 -59
- Misses 25612 25682 +70
- Partials 3848 3878 +30 ☔ View full report in Codecov by Sentry. |
some tests are failing, is all yet updated for the new state? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not quite ready. The cleanup timer should only close inactive or opening channels.
A channel enters inactive state if an active session is closed.
Once inactive, the timer checks inactivity and closes it.
@mregen, please review the updates. |
testing this next... |
…cks" This reverts commit 82e0c02.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comment on AcceptSocket, it should be closed right away?
tested and looks all good to me.. |
Proposed changes
Added a limit to the number of Channels on the server side and removed "stale" channels.
Add option to console client to leak channels and run forever.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...