Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Role Permissions of Method UnregisterApplication & Add Parameter to CertificateStoreIdentifier OpenStore Method #2558

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Mar 16, 2024

Proposed changes

Fix allowed Roles of Method Unregister Application allow Application Self Admin Privilge:
https://reference.opcfoundation.org/GDS/v105/docs/6.6.8

Add Parameter NoPrivateKeys to OpenStoreMethod of CertificateStoreIdentifier

Related Issues

  • Fixes #

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.53%. Comparing base (3f29a72) to head (5865efa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
- Coverage   54.55%   53.53%   -1.02%     
==========================================
  Files         335      335              
  Lines       64749    64750       +1     
  Branches    13292    13292              
==========================================
- Hits        35325    34666     -659     
- Misses      25594    26271     +677     
+ Partials     3830     3813      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett romanett changed the title fix Role Permissions of Method UnregisterApplication fix Role Permissions of Method UnregisterApplication & Add Parameter to CertificateStoreIdenfier OpenStore Method Mar 19, 2024
@romanett romanett changed the title fix Role Permissions of Method UnregisterApplication & Add Parameter to CertificateStoreIdenfier OpenStore Method fix Role Permissions of Method UnregisterApplication & Add Parameter to CertificateStoreIdentifier OpenStore Method Mar 19, 2024
@mregen mregen added this to the March Update milestone Mar 25, 2024
@mregen mregen merged commit 48fd872 into OPCFoundation:master Mar 26, 2024
44 of 45 checks passed
@romanett romanett deleted the fixPermissionsUnregister branch April 4, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants