Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved naming of Property filters #119

Closed
hhgs opened this issue Nov 5, 2013 · 2 comments
Closed

Improved naming of Property filters #119

hhgs opened this issue Nov 5, 2013 · 2 comments
Labels
Enhancement An addition that can be observed by the user

Comments

@hhgs
Copy link
Member

hhgs commented Nov 5, 2013

A new property filter should be named according to the selected property, like "EQLNUM(1)", and not "New Filter (1)".

@JacobStoren JacobStoren added the Enhancement An addition that can be observed by the user label Jun 23, 2015
@JacobStoren
Copy link
Member

I have done this now, but I keep wondering if we should go one step further:

  • Keep changing the name automatically as the user selects other properties to filter on.
  • Disable the possibiity for the user to edit the filter name

Because you will end up with filters "lying" about their behaviour if not.
We could also keep track of whether the user has changed the value, but that seems to be a bit over the top.

How much is the possibility to edit the filter name actually used ?
We could also just overwrite what the user might have entered.

@JacobStoren
Copy link
Member

Property filters now automatically updates their names according to the filters settings:
Eclipse:

 ResultName (low .. high)

Geomech:

 ResultPos, Field, Component (low .. high)

It is still possible to edit the name by hand, but this will be overwritten if changing the filters setting.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An addition that can be observed by the user
Projects
None yet
Development

No branches or pull requests

2 participants