Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop matching wild on wild card #40

Merged
merged 3 commits into from
Mar 12, 2013
Merged

Stop matching wild on wild card #40

merged 3 commits into from
Mar 12, 2013

Conversation

rcpeters
Copy link
Contributor

Pushing this out early just so external people can see what is going on.

  1. Still need to do some nginx work on production
  2. Still need to do more integration testing.

@gthorisson
Copy link

great, thanks Rob. I'll include the pull URL in the response to the list:

#40

    M

On 12.3.2013, at 17:47, Robert Peters notifications@github.com wrote:

Pushing this out early just so external people can see what is going on.

  1. Still need to do some nginx work on production
  2. Still need to do more integration testing.

You can merge this Pull Request by running

git pull https://github.com/ORCID/ORCID-Source dev-preventWildHeader
Or view, comment on, or merge it at:

#40

Commit Summary

• Stop matching wild on wild card
File Changes

• M orcid-api-common/src/main/java/org/orcid/api/common/OrcidApiService.java (10)
• M orcid-api-common/src/main/java/org/orcid/api/common/jaxb/OrcidExceptionMapper.java (4)
• M orcid-api-common/src/main/java/org/orcid/api/common/jaxb/OrcidMarshallerContextResolver.java (4)
• M orcid-api-common/src/main/java/org/orcid/api/common/jaxb/OrcidValidationJaxbContextResolver.java (4)
• M orcid-api-web/src/main/java/org/orcid/api/t2/T2OrcidApiService.java (24)
• M orcid-api-web/src/main/java/org/orcid/api/t2/server/T2OrcidApiServiceImpl.java (36)
• M orcid-api-web/src/test/java/org/orcid/api/t2/OAuthOrcidApiService.java (10)
• M orcid-api-web/src/test/java/org/orcid/api/t2/T2OAuthAPIService.java (20)
• M orcid-api-web/src/test/java/org/orcid/api/t2/integration/T2OAuthOrcidApiClientImpl.java (30)
• M orcid-pub-web/src/main/java/org/orcid/api/t1/server/T1OrcidApiServiceImpl.java (10)
Patch Links:

https://github.com/ORCID/ORCID-Source/pull/40.patch
https://github.com/ORCID/ORCID-Source/pull/40.diff

@rcpeters
Copy link
Contributor Author

Sure just make sure they know that we still have to do some major nginx foo
as to not have people using our API (incorrectly) break. I hope to have
that figured out shortly.

Cheers,
Rob

On Tue, Mar 12, 2013 at 10:56 AM, Gudmundur A. Thorisson <
notifications@github.com> wrote:

great, thanks Rob. I'll include the pull URL in the response to the list:

#40

M

On 12.3.2013, at 17:47, Robert Peters notifications@github.com wrote:

Pushing this out early just so external people can see what is going on.

  1. Still need to do some nginx work on production
  2. Still need to do more integration testing.

You can merge this Pull Request by running

git pull https://github.com/ORCID/ORCID-Source dev-preventWildHeader
Or view, comment on, or merge it at:

#40

Commit Summary

• Stop matching wild on wild card
File Changes

• M
orcid-api-common/src/main/java/org/orcid/api/common/OrcidApiService.java
(10)
• M
orcid-api-common/src/main/java/org/orcid/api/common/jaxb/OrcidExceptionMapper.java
(4)
• M
orcid-api-common/src/main/java/org/orcid/api/common/jaxb/OrcidMarshallerContextResolver.java
(4)
• M
orcid-api-common/src/main/java/org/orcid/api/common/jaxb/OrcidValidationJaxbContextResolver.java
(4)
• M orcid-api-web/src/main/java/org/orcid/api/t2/T2OrcidApiService.java
(24)
• M
orcid-api-web/src/main/java/org/orcid/api/t2/server/T2OrcidApiServiceImpl.java
(36)
• M
orcid-api-web/src/test/java/org/orcid/api/t2/OAuthOrcidApiService.java (10)
• M orcid-api-web/src/test/java/org/orcid/api/t2/T2OAuthAPIService.java
(20)
• M
orcid-api-web/src/test/java/org/orcid/api/t2/integration/T2OAuthOrcidApiClientImpl.java
(30)
• M
orcid-pub-web/src/main/java/org/orcid/api/t1/server/T1OrcidApiServiceImpl.java
(10)
Patch Links:

https://github.com/ORCID/ORCID-Source/pull/40.patch
https://github.com/ORCID/ORCID-Source/pull/40.diff


Reply to this email directly or view it on GitHubhttps://github.com//pull/40#issuecomment-14791755
.

Robert Peters
info@rcpeters.com
805.440.9056

@rcpeters
Copy link
Contributor Author

This now looks to be figured out and will go out in the next release cycle. 3-10 days.

rcpeters added a commit that referenced this pull request Mar 12, 2013
@rcpeters rcpeters merged commit 3bd7365 into master Mar 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants