fix locale fallbacks so they actually fallback #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Very cool, even worked when I generated errors. I never experienced any issues but I couldn't remember if you had said something about the File app not working right. If I'm mistaken, I'm good to merge it in. |
|
I left comments on the bug ticket about how/where errors appear in the files app. |
|
I mean if you have locale set to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1252.
I can really only test this manually - but here's the test where Cluster dropdown could be in
zh-CN, but there's no translation for them so they're in english. I.e., the fallback to english worked.There's not clean way to test in system or integration tests because the system boots up and sets defaults (english) that, even if you override in a test case, everything's already setup, you can't reset it. So looks like we'll have to add some end-to-end coverage for locales.