Locale Fallback Fix #1284
Closed
Locale Fallback Fix #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o config/application.rb
johrstrom
reviewed
Jul 12, 2021
| @@ -35,6 +35,12 @@ class Application < Rails::Application | |||
| # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded. | |||
| # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s] | |||
| # config.i18n.default_locale = :de | |||
| config.i18n.default_locale = :en | |||
| config.i18n.available_locales = %i(en zh-CN) | |||
There was a problem hiding this comment.
I'm not sure if we can specify available locales given some folks may have provided their own at their site without pushing it back to us.
johrstrom
requested changes
Jul 12, 2021
|
This doesn't actually fallback like you'd expect. I think we need to remove some bits out of the controller and that initializer. In any case, there's a replacement in #1314, so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes location of locale settings to config/application.rb and adds more explicit settings for fallback to behave properly.