Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bug#1322 #1346

Closed
wants to merge 3 commits into from
Closed

fixed bug#1322 #1346

wants to merge 3 commits into from

Conversation

ayushchatur
Copy link
Contributor

fixed #1322

@johrstrom
Copy link
Contributor

Your commits don't seem to be associated with your GH user. Is it the right user.email git config?

@ayushchatur
Copy link
Contributor Author

@johrstrom rebased with correct author

@johrstrom johrstrom self-requested a review August 23, 2021 17:09
johrstrom
johrstrom requested changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it is. This still has 3 commits - one of them from the unknown user.

@ayushchatur ayushchatur mentioned this pull request Aug 23, 2021
Merged
@ayushchatur
Copy link
Contributor Author

raise another #1359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom requested changes

Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New file error isn't formatted right
3 participants
@ayushchatur @johrstrom @oscwiag