Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline .clickable on hover #3138

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

HazelGrant
Copy link
Contributor

Fixes issue #3136

Would there be anywhere .clickable is used where we WOULDN'T want it to indicate with an underline on hover? Also, do we want to bother with active/inactive colors as well?

Screenshot 2023-10-26 at 1 47 46 PM

@johrstrom
Copy link
Contributor

Would there be anywhere .clickable is used where we WOULDN'T want it to indicate with an underline on hover?

We can seperate them later if it comes to it.

Also, do we want to bother with active/inactive colors as well?

Not sure if we can because they're not actually anchors (a tag), but I could be wrong on this. In any case, if we can, then yea I think so.

@johrstrom
Copy link
Contributor

Your commit does not appear to be correctly associated with your Github account.

Your github account can be associated with many email addresses. For example, mine is associated with both my @osc.edu and my personal email.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine, but you need to fix the commit so it's correctly tied to your GH user.

@HazelGrant HazelGrant force-pushed the 3136-path-selector-directory-ui-fix branch 2 times, most recently from d55a25b to 961fa49 Compare October 26, 2023 19:17
@HazelGrant
Copy link
Contributor Author

I added my @osc.edu email to my account, and updated the author on the commit. From my environment the author/email are not correct but it still looks messed up on GH. What is it specifically you're looking at? I'm considering closing this PR and submitting a clean commit now - would that help?

@johrstrom
Copy link
Contributor

Before it looked like this

image

Now it looks like this - GH is tripped up by the 2 different users (one author one committer). I'll pull the branch and look at the actual commit now.

image

@johrstrom
Copy link
Contributor

I'm considering closing this PR and submitting a clean commit now - would that help?

Probably - it looks like you've setup git correctly now. I'm sure there's some way to fix the commit, but if I get into trouble with git I tend to start over, so yea maybe a brand new commit is easier.

I have no preference if it's a force update to this branch/PR or another one.

@HazelGrant HazelGrant force-pushed the 3136-path-selector-directory-ui-fix branch from 961fa49 to 9863143 Compare October 26, 2023 19:41
@johrstrom johrstrom self-requested a review October 26, 2023 19:42
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - This commit will work fine for me as it is now.

The author is correctly your GH user so that's good enough. The committer isn't a GH user, but that's OK by me. Or at least it's not big enough to hold this up any longer.

@HazelGrant HazelGrant force-pushed the 3136-path-selector-directory-ui-fix branch from 9863143 to cba4c0d Compare October 26, 2023 19:45
@HazelGrant
Copy link
Contributor Author

I think it's fixed now anyway.

@HazelGrant HazelGrant merged commit d84bdbc into master Oct 26, 2023
23 checks passed
@HazelGrant HazelGrant deleted the 3136-path-selector-directory-ui-fix branch October 26, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants