-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underline .clickable on hover #3138
Conversation
We can seperate them later if it comes to it.
Not sure if we can because they're not actually anchors ( |
Your commit does not appear to be correctly associated with your Github account. Your github account can be associated with many email addresses. For example, mine is associated with both my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are fine, but you need to fix the commit so it's correctly tied to your GH user.
d55a25b
to
961fa49
Compare
I added my @osc.edu email to my account, and updated the author on the commit. From my environment the author/email are not correct but it still looks messed up on GH. What is it specifically you're looking at? I'm considering closing this PR and submitting a clean commit now - would that help? |
Probably - it looks like you've setup git correctly now. I'm sure there's some way to fix the commit, but if I get into trouble with git I tend to start over, so yea maybe a brand new commit is easier. I have no preference if it's a force update to this branch/PR or another one. |
961fa49
to
9863143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - This commit will work fine for me as it is now.
The author is correctly your GH user so that's good enough. The committer isn't a GH user, but that's OK by me. Or at least it's not big enough to hold this up any longer.
9863143
to
cba4c0d
Compare
I think it's fixed now anyway. |
Fixes issue #3136
Would there be anywhere
.clickable
is used where we WOULDN'T want it to indicate with an underline on hover? Also, do we want to bother with active/inactive colors as well?