Skip to content
This repository has been archived by the owner on Nov 13, 2019. It is now read-only.

[DO NOT MERGE] Add cluster config validation #402

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Add cluster config validation #402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ea2abea
add config validation
AriettaZ Sep 24, 2018
98eaca1
raise error and add option argument
AriettaZ Sep 25, 2018
a969184
add validate before testing jobs
AriettaZ Sep 27, 2018
de089da
remove env file
AriettaZ Sep 27, 2018
aabee7c
handle environment variable
AriettaZ Sep 28, 2018
070be3f
remove test.yml
AriettaZ Sep 28, 2018
48b0587
handle syntax error
AriettaZ Nov 27, 2018
293032b
catch other error when loading yaml
AriettaZ Nov 27, 2018
7171679
update gems
AriettaZ Nov 27, 2018
94570d3
update gems
AriettaZ Nov 27, 2018
b0c73f5
Merge branch 'master' of github.com:OSC/ood-dashboard into add-valida…
AriettaZ Nov 29, 2018
1c2975b
try solve travis error
AriettaZ Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Expand Up @@ -59,9 +59,11 @@ gem 'rails_12factor', group: :production
gem 'mocha', '~> 1.1', group: :test
gem "spring", group: :test
gem 'autoprefixer-rails', '~> 8.4'
gem 'json-schema', '~> 2.8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a JSON schema validator when there are YAML validators available? For example: kwalify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I didn't see this. http://www.kuwata-lab.com/kwalify/ looks interesting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used https://www.jsonschema.net/ to generate JSON schema but there's nothing similar for YAML. To save time writing schema(that's hundreds of lines), I think JSON schema validator would be a better choice for now.


# OOD specific gems
gem 'ood_support', '~> 0.0.2'
gem 'ood_appkit', '~> 1.0'
gem 'ood_core', '~> 0.1'
gem 'pbs', '~> 2.2.1'

3 changes: 3 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Expand Up @@ -84,6 +84,8 @@ GEM
railties (>= 4.2.0)
thor (>= 0.14, < 2.0)
json (1.8.6)
json-schema (2.8.0)
addressable (>= 2.4)
lograge (0.10.0)
actionpack (>= 4)
activesupport (>= 4)
Expand Down Expand Up @@ -203,6 +205,7 @@ DEPENDENCIES
jbuilder (~> 2.0)
jquery-datatables-rails (~> 3.4)
jquery-rails
json-schema (~> 2.8)
mocha (~> 1.1)
ood_appkit (~> 1.0)
ood_core (~> 0.1)
Expand Down