Skip to content
This repository has been archived by the owner on Nov 13, 2019. It is now read-only.

Develop dropdown visibility #94

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Conversation

ericfranz
Copy link
Contributor

Fixes #74

@ericfranz
Copy link
Contributor Author

Maybe NavConfig.developer_mode instead of NavConfig.show_develop_dropdown so we can use this in other places where it makes sense.

@ericfranz ericfranz self-assigned this Dec 13, 2016
Copy link
Contributor

@nickjer nickjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, although developer_mode would be beneficial but not in this context. I could see developer_mode providing menus/forms for registering as a developer if not already one. As well as displaying shared apps.

But you will still need a boolean that determines whether the current user "is a developer". Something like developer?. E.g.:

<%= render partial: 'layouts/nav/develop_dropdown' if NavConfig.developer_mode? && NavConfig.developer? %>

@nickjer
Copy link
Contributor

nickjer commented Dec 13, 2016

Although I also wouldn't be opposed to a separate object that describes Developer properties.

@nickjer
Copy link
Contributor

nickjer commented Dec 13, 2016

I also would enable developer_mode as you have done, if ENV["OOD_APP_SHARING"].present?

@ericfranz ericfranz merged commit aa378e1 into master Dec 13, 2016
@ericfranz ericfranz deleted the develop_dropdown_visibility branch December 13, 2016 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants