Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OodCore: Fix gpus_from_gres unreadable from Job::Adapters::Slurm::Batch #762

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

lukew3
Copy link
Contributor

@lukew3 lukew3 commented Jun 7, 2022

As of v0.20.0, cluster_info is unable to be retrieved since gpus_from_gres is inaccessible from Slurm::Batch. Making gpus_from_gres a class method of Slurm and calling Slurm.gpus_from_gres inside of Batch corrects this. Not sure how this issue came to be as I remember it working when we merged.

┆Issue is synchronized with this Asana task by Unito

@lukew3 lukew3 requested a review from johrstrom June 7, 2022 17:08
@lukew3 lukew3 changed the title Fix gpus_from_gres unreadable from Slurm::Batch job adapter Fix gpus_from_gres unreadable from Job::Adapters::Slurm::Batch Jun 7, 2022
@sync-by-unito sync-by-unito bot changed the title Fix gpus_from_gres unreadable from Job::Adapters::Slurm::Batch OodCore: Fix gpus_from_gres unreadable from Job::Adapters::Slurm::Batch Jun 15, 2022
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@johrstrom johrstrom merged commit 9de0518 into master Jul 28, 2022
@johrstrom johrstrom deleted the lukew3-cluster-info-gpus-from-gres-patch branch July 28, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants