Feature/fdp 1628 #7

LucianoFavoroso · 2023-11-14T09:49:37Z

No description provided.

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

JelleHoffman

There are still Sonar Encryption errors?

JelleHoffman

Sonar issues are false postives, therefore approved

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskControllerTest.kt

sanderv · 2023-11-21T11:42:57Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskControllerTest.kt

+class PskControllerTest {
+
+    @Autowired
+    private lateinit var mockMvc: MockMvc


Geen technische namen

Deze vind ik lastig heb je een suggestie?

Bijvoorbeeld pskRequest, dat is wat je uitvoert met dit object in de code

sanderv · 2023-11-21T11:45:14Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskServiceTest.kt

+        val expectedKey = "1234"
+        pskRepository.save(Psk(IDENTITY, Instant.MAX, expectedKey))
+
+        val currentPks = pskService.getCurrentPsk(IDENTITY)


Typo: currentPsk, niet Pks

sanderv · 2023-11-21T12:48:32Z

application/src/main/kotlin/org/gxf/crestdeviceservice/coap/DownlinkService.kt

+    }
+
+    private fun constructSetPskCommand(key: String): String {
+        return "PSK:${key};PSK:${key}SET"


mag zonder { }

sanderv · 2023-11-21T12:55:48Z

application/src/main/kotlin/org/gxf/crestdeviceservice/psk/PskService.kt

+    }
+
+    private fun generatePsk(): String {
+        val allowedChars = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"


Deze kan ook als constant

sanderv · 2023-11-21T12:58:33Z

application/src/test/kotlin/DatabaseFieldEncryptorTest.kt

+    @Test
+    fun shouldBeAbleTeEncryptAndDecryptData() {
+        val expected = "data"
+        val encrypted = databaseFieldEncryptor.convertToDatabaseColumn(expected)


Suggestie: zet hier een extra assert tussen om aan tegeven dat encrypted != expected. Nu toont je test aan dat de encryptor z'n werk perfect doet of dat 'ie helemaal niks doet...

smvdheijden · 2023-11-21T10:50:23Z

build.gradle.kts

@@ -39,7 +39,7 @@ subprojects {

    group = "org.gxf.template"
    version = rootProject.version
-
+    


Remove whitespace

smvdheijden · 2023-11-22T13:22:33Z

application/build.gradle.kts

    implementation("org.springframework.boot:spring-boot-starter-actuator")
    implementation("org.springframework.boot:spring-boot-starter-web")
+
    implementation("org.jetbrains.kotlin:kotlin-reflect")
    implementation("org.springframework:spring-aop")
    implementation("io.github.microutils:kotlin-logging-jvm:3.0.5")

+    implementation("org.postgresql:postgresql:42.5.4")
+    implementation("org.flywaydb:flyway-core:9.22.3")
+
+    implementation("org.springframework.boot:spring-boot-starter-data-jpa:3.1.5")

    implementation("org.springframework.boot:spring-boot-autoconfigure")
    implementation("org.springframework.boot:spring-boot-starter-logging")

    implementation("org.springframework:spring-aspects")
-    implementation("org.springframework:spring-aop")

    implementation("org.springframework.kafka:spring-kafka")
    implementation("com.microsoft.azure:msal4j:1.13.10")


verify if the versions are not provided by spring boot starter(s)

try to keep the dependencies organized in a logical manner.

consider using a version catalogue for managing the dependencies.

smvdheijden · 2023-11-22T13:24:17Z

application/build.gradle.kts

+                implementation("org.springframework.boot:spring-boot-starter-data-jpa:3.1.5")
                implementation("com.gxf.utilities:kafka-avro:0.2")
                implementation("org.springframework.kafka:spring-kafka")
                implementation("org.springframework.boot:spring-boot-starter-test")
                implementation("org.springframework.kafka:spring-kafka-test")
                implementation("org.testcontainers:kafka:1.17.6")
                implementation("org.springframework.ws:spring-ws-test")
+                runtimeOnly("com.h2database:h2:2.2.224")
+                implementation("org.mockito.kotlin:mockito-kotlin:5.1.0")


See previous comment regarding versions

smvdheijden · 2023-11-22T13:36:57Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskControllerTest.kt

+
+    @Test
+    fun shouldReturnKeyForIdentity() {
+        Mockito.`when`(mock.getCurrentPsk(any())).thenReturn("key")


Suggested change

Mockito.`when`(mock.getCurrentPsk(any())).thenReturn("key")

`when`(mock.getCurrentPsk(any())).thenReturn("key")

smvdheijden · 2023-11-22T13:37:56Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskControllerTest.kt

+
+    @Test
+    fun shouldReturn404WhenPskForIdentityIsNotFound() {
+        Mockito.`when`(mock.getCurrentPsk(any())).thenReturn(null)


Import static method, so that the code becomes:

Suggested change

Mockito.`when`(mock.getCurrentPsk(any())).thenReturn(null)

`when`(mock.getCurrentPsk(any())).thenReturn(null)

smvdheijden · 2023-11-22T13:59:29Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskServiceTest.kt

+import org.gxf.crestdeviceservice.data.entity.Psk
+import org.gxf.crestdeviceservice.psk.PskRepository
+import org.gxf.crestdeviceservice.psk.PskService
+import org.junit.jupiter.api.Assertions.*


Use AssertJ for assertions

smvdheijden · 2023-11-22T14:05:07Z

application/src/integrationTest/resources/application.yaml

+    dev-initial-psk: "ABCDEFGHIJKLMNOP" #Should be the same as the PSK in the simulator only relevant for dev
+    dev-device-identity: "867787050253370" #Should be the same as the identity in the simulator only relevant for dev


I would prefer to have:

dev properties in a separate application-dev.yaml file

comments on a separate line:

Suggested change

dev-initial-psk: "ABCDEFGHIJKLMNOP" #Should be the same as the PSK in the simulator only relevant for dev

dev-device-identity: "867787050253370" #Should be the same as the identity in the simulator only relevant for dev

# Initial PSK should be the same as the PSK in the simulator, only relevant for dev

dev-initial-psk: "ABCDEFGHIJKLMNOP"

# Identity should be the same as the identity in the simulator, only relevant for dev

dev-device-identity: "867787050253370"

I do not know what our plans regarding integration tests are and how spring profiles fit in. For now I suggest to keep it like this and update when needed. Comments on new line is done.

smvdheijden · 2023-11-22T14:25:39Z

application/src/main/kotlin/org/gxf/crestdeviceservice/data/CommandLineRunnerDevDatabaseInit.kt

+
+    /***
+     * Setup function for local development.
+     * Runs flyway migrations manual, because the CommandLineRunner is run before spring runs the flyway migrations automatically.


Suggested change

* Runs flyway migrations manual, because the CommandLineRunner is run before spring runs the flyway migrations automatically.

* Runs flyway migrations manually, because the CommandLineRunner is run before spring runs the flyway migrations automatically.

smvdheijden · 2023-11-22T14:26:23Z

application/src/main/kotlin/org/gxf/crestdeviceservice/data/CommandLineRunnerDevDatabaseInit.kt

+        val flyway = Flyway.configure()
+                .dataSource(dataSourceProperties.url, dataSourceProperties.username, dataSourceProperties.password)
+                .load()


Suggested change

val flyway = Flyway.configure()

.dataSource(dataSourceProperties.url, dataSourceProperties.username, dataSourceProperties.password)

.load()

val flyway = Flyway

.configure()

.dataSource(dataSourceProperties.url, dataSourceProperties.username, dataSourceProperties.password)

.load()

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt

smvdheijden

Add license headers!!!
Use AssertJ assertions

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt

smvdheijden · 2023-11-23T10:49:54Z

application/build.gradle.kts

    implementation("org.springframework.boot:spring-boot-starter-actuator")
    implementation("org.springframework.boot:spring-boot-starter-web")
+
    implementation("org.jetbrains.kotlin:kotlin-reflect")
    implementation("org.springframework:spring-aop")
    implementation("io.github.microutils:kotlin-logging-jvm:3.0.5")

+    implementation("org.postgresql:postgresql:42.5.4")
+    implementation("org.flywaydb:flyway-core:9.22.3")
+
+    implementation("org.springframework.boot:spring-boot-starter-data-jpa:3.1.5")

    implementation("org.springframework.boot:spring-boot-autoconfigure")
    implementation("org.springframework.boot:spring-boot-starter-logging")

    implementation("org.springframework:spring-aspects")
-    implementation("org.springframework:spring-aop")

    implementation("org.springframework.kafka:spring-kafka")
    implementation("com.microsoft.azure:msal4j:1.13.10")


Verify for each dependency if the version is really needed or already supplied via Spring Boot

Consider organizing the dependencies (alphabetically and/or grouped by feature?)

Consider using a version catalogue for dependency management

smvdheijden · 2023-11-23T10:50:45Z

application/build.gradle.kts

                implementation(project())
                implementation(project(":components:avro-measurement"))
+                implementation("org.springframework.boot:spring-boot-starter-data-jpa:3.1.5")
                implementation("com.gxf.utilities:kafka-avro:0.2")
                implementation("org.springframework.kafka:spring-kafka")
                implementation("org.springframework.boot:spring-boot-starter-test")
                implementation("org.springframework.kafka:spring-kafka-test")
                implementation("org.testcontainers:kafka:1.17.6")
                implementation("org.springframework.ws:spring-ws-test")
+                runtimeOnly("com.h2database:h2:2.2.224")
+                implementation("org.mockito.kotlin:mockito-kotlin:5.1.0")


See previous comment regarding dependencies

smvdheijden · 2023-11-23T10:51:59Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskControllerTest.kt

+
+    @Test
+    fun shouldReturn404WhenPskForIdentityIsNotFound() {
+        Mockito.`when`(mock.getCurrentPsk(any())).thenReturn(null)


Use static method imports for Mockito.`when`

smvdheijden · 2023-11-23T10:52:52Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PskControllerTest.kt

+                MockMvcRequestBuilders.get("/psk")
+                        .header("x-device-identity", "identity"))


I would prefer this layout for better readability.

Suggested change

MockMvcRequestBuilders.get("/psk")

.header("x-device-identity", "identity"))

MockMvcRequestBuilders

.get("/psk")

.header("x-device-identity", "identity"))

smvdheijden · 2023-11-23T16:10:17Z

application/src/main/resources/application-dev.yaml

+    dev-initial-psk: "ABCDEFGHIJKLMNOP" #Should be the same as the PSK in the simulator only relevant for dev
+    dev-device-identity: "867787050253370" #Should be the same as the identity in the simulator only relevant for dev


Suggested change

dev-initial-psk: "ABCDEFGHIJKLMNOP" #Should be the same as the PSK in the simulator only relevant for dev

dev-device-identity: "867787050253370" #Should be the same as the identity in the simulator only relevant for dev

# Initial PSK should be the same as the PSK in the simulator, only relevant for dev

initial-psk: "ABCDEFGHIJKLMNOP"

# Device identity should be the same as the identity in the simulator, only relevant for dev

device-identity: "867787050253370"

smvdheijden · 2023-11-23T16:11:08Z

application/src/test/kotlin/DownlinkServiceTest.kt

Move class to package org.gxf.crestdeviceservice.coap

smvdheijden · 2023-11-23T16:11:41Z

application/src/test/kotlin/DownlinkServiceTest.kt

@@ -0,0 +1,40 @@
+import org.gxf.crestdeviceservice.coap.DownlinkService


Import should not be needed when test class is in same package as class under test.

smvdheijden · 2023-11-23T16:38:43Z

application/src/main/kotlin/org/gxf/crestdeviceservice/data/CommandLineRunnerDevDatabaseInit.kt

+    /***
+     * Setup function for local development.
+     * Runs flyway migrations manual, because the CommandLineRunner is run before spring runs the flyway migrations automatically.
+     * Sets the psk used by the simulator if it doesn't exist.
+     */
+    override fun run(vararg args: String?) {
+        val flyway = Flyway.configure()
+                .dataSource(dataSourceProperties.url, dataSourceProperties.username, dataSourceProperties.password)
+                .load()
+
+        flyway.migrate()


Have you tried adding @DependsOn({"flyway", "flywayInitializer"}) annotation to the class?

smvdheijden · 2023-11-23T16:44:50Z

application/src/main/kotlin/org/gxf/crestdeviceservice/coap/DownlinkService.kt

+    fun getDownlinkForIdentity(identity: String): String {
+
+        if (pskService.hasDefaultKey(identity)) {
+            logger.info { "Device $identity has default key creating new key " }
+
+            val newKey = pskService.generateAndSetNewKeyForIdentity(identity)
+
+            return constructSetPskCommand(newKey)
+        }
+
+        return "0"
+    }


Probably sufficient for now, but in the (near) future we might also have to handle other downlinks as well...
I'm wondering if it should be the responsibility of the downlink service to check and recreate PSKs...

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

smvdheijden · 2023-12-04T16:37:25Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/MessageHandelingTest.kt


        val consumer = createKafkaConsumer(embeddedKafkaBroker, crestMessageTopicName)
        val response = testRestTemplate.postForEntity("/sng/1", request, String::class.java)

-        Assertions.assertEquals("0", response.body)
+        assertThat("0").isEqualTo(response.body)


Wrong order of actual and expected values

smvdheijden · 2023-12-04T16:37:53Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/MessageHandelingTest.kt


        val expectedJsonNode = ObjectMapper().readTree(getFileContentAsString("message.json"))
        val payloadJsonNode = ObjectMapper().readTree(records.records(crestMessageTopicName).first().value().payload)

-        Assertions.assertEquals(expectedJsonNode, payloadJsonNode)
+        assertThat(expectedJsonNode).isEqualTo(payloadJsonNode)


Wrong order of actual and expected values

smvdheijden · 2023-12-04T16:39:29Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/MessageHandelingTest.kt

 import org.testcontainers.shaded.com.fasterxml.jackson.databind.ObjectMapper
 import java.time.Duration

 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
 @EmbeddedKafka(
        topics = ["\${crest-device-service.kafka.message-producer.topic-name}"],
 )
+@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD)
 class MessageHandelingTest {


Fix typo, also rename file.

Suggested change

class MessageHandelingTest {

class MessageHandlingTest {

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PreSharedKeyRetrieveTest.kt

smvdheijden · 2023-12-04T16:42:40Z

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/PreSharedKeyRetrieveTest.kt

+        val result = restTemplate.exchange("/psk",
+                HttpMethod.GET, HttpEntity<Unit>(headers), String::class.java)
+
+        assertThat("0000111122223333").isEqualTo(result.body)


Switch actual and expected values.

smvdheijden · 2023-12-04T16:51:28Z

application/src/test/kotlin/org/gxf/crestdeviceservice/coap/DownlinkServiceTest.kt

@@ -24,7 +25,7 @@ class DownlinkServiceTest {

        val result = downLinkService.getDownlinkForIdentity("identity")

-        assertEquals("0", result)
+        assertThat("0").isEqualTo(result)


Switch actual and expected values

smvdheijden · 2023-12-04T16:51:55Z

application/src/test/kotlin/org/gxf/crestdeviceservice/coap/DownlinkServiceTest.kt

@@ -35,6 +36,6 @@ class DownlinkServiceTest {
        val result = downLinkService.getDownlinkForIdentity("identity")

        // Psk command is formatted as: PSK:[Key];PSK:[Key]SET
-        assertEquals("PSK:key;PSK:keySET", result)
+        assertThat("PSK:key;PSK:keySET").isEqualTo(result)


Switch actual and expected values

smvdheijden · 2023-12-04T16:53:25Z

...ion/src/test/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptorTest.kt

+        assertThat("data").isNotEqualTo(encrypted)
+        assertThat(expected).isEqualTo(decrypted)


Switch actual and expected values.

Suggested change

assertThat("data").isNotEqualTo(encrypted)

assertThat(expected).isEqualTo(decrypted)

assertThat(encrypted).isNotEqualTo("data")

assertThat(decrypted).isEqualTo(expected)

smvdheijden · 2023-12-04T16:54:14Z

settings.gradle.kts

+
+            library("microsoftMsal", "com.microsoft.azure", "msal4j").version("1.13.10")
+
+            library("assertJ", "org.assertj", "assertj-core").version("3.24.2")


Isn't the version provided by Spring Boot?

smvdheijden · 2023-12-04T16:54:38Z

settings.gradle.kts

+            library("kafkaTestContainers", "org.testcontainers", "kafka").version("1.17.6")
+        }
+    }
+}


Add newline

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

# Conflicts: # application/src/test/kotlin/MeasurementProducerTest.kt

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/MessageHandlingTest.kt

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

sonarcloud · 2023-12-05T13:12:35Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

77.0% Coverage
0.0% Duplication

LucianoFavoroso added 4 commits November 14, 2023 10:41

FDP-1628: added psk

e09bd75

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

FDP-1628: wording

d92a19e

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

FDP-1628: formatting

b03b083

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

FDP-1628: fix test

cbb9b13

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

github-advanced-security bot found potential problems Nov 14, 2023

View reviewed changes

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt Fixed Show fixed Hide fixed

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt Fixed Show fixed Hide fixed

LucianoFavoroso added 2 commits November 14, 2023 11:41

FDP-1628: added stronger encryption

bcee540

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

FDP-1628: fix test

cf15d31

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

github-advanced-security bot found potential problems Nov 14, 2023

View reviewed changes

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt Fixed Show resolved Hide resolved

...ication/src/main/kotlin/org/gxf/crestdeviceservice/data/convertors/DatabaseFieldEncryptor.kt Fixed Show fixed Hide fixed

FDP-1628: fix encryption

f91c514

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

JelleHoffman reviewed Nov 21, 2023

View reviewed changes

JelleHoffman approved these changes Nov 21, 2023

View reviewed changes

sanderv reviewed Nov 21, 2023

View reviewed changes

smvdheijden reviewed Nov 23, 2023

View reviewed changes

smvdheijden requested changes Nov 23, 2023

View reviewed changes

LucianoFavoroso added 4 commits November 27, 2023 14:44

FDP-1628: comments Sander not complete

3a8e853

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

FDP-1628: comments Sander

b104ab6

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

FDP-1628: fix test

e239dbb

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

FDP-1628: fixed some naming

f31bd1e

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

smvdheijden requested changes Dec 4, 2023

View reviewed changes

LucianoFavoroso added 2 commits December 5, 2023 10:00

FDP-1628: comments Sander

ed5a999

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

Merge branch 'main' into feature/FDP-1628

5eb23a9

# Conflicts: # application/src/test/kotlin/MeasurementProducerTest.kt

smvdheijden requested changes Dec 5, 2023

View reviewed changes

application/src/integrationTest/kotlin/org/gxf/crestdeviceservice/MessageHandlingTest.kt Outdated Show resolved Hide resolved

FDP-1628: comments Sander

5461396

Signed-off-by: Luciano Favoroso <luciano.favoroso@alliander.com>

smvdheijden approved these changes Dec 5, 2023

View reviewed changes

smvdheijden merged commit 45aa4dc into main Dec 5, 2023
4 checks passed

smvdheijden deleted the feature/FDP-1628 branch December 5, 2023 13:16

		@@ -39,7 +39,7 @@ subprojects {

		group = "org.gxf.template"
		version = rootProject.version

	Mockito.`when`(mock.getCurrentPsk(any())).thenReturn("key")
	`when`(mock.getCurrentPsk(any())).thenReturn("key")

		dev-initial-psk: "ABCDEFGHIJKLMNOP" #Should be the same as the PSK in the simulator only relevant for dev
		dev-device-identity: "867787050253370" #Should be the same as the identity in the simulator only relevant for dev

	* Runs flyway migrations manual, because the CommandLineRunner is run before spring runs the flyway migrations automatically.
	* Runs flyway migrations manually, because the CommandLineRunner is run before spring runs the flyway migrations automatically.

		MockMvcRequestBuilders.get("/psk")
		.header("x-device-identity", "identity"))

		@@ -0,0 +1,40 @@
		import org.gxf.crestdeviceservice.coap.DownlinkService

		assertThat("data").isNotEqualTo(encrypted)
		assertThat(expected).isEqualTo(decrypted)


		library("microsoftMsal", "com.microsoft.azure", "msal4j").version("1.13.10")

		library("assertJ", "org.assertj", "assertj-core").version("3.24.2")

Feature/fdp 1628 #7

Feature/fdp 1628 #7

Conversation

LucianoFavoroso commented Nov 14, 2023

JelleHoffman left a comment

Choose a reason for hiding this comment

JelleHoffman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smvdheijden left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Dec 5, 2023