Adding block-scoped comments in eqearth code #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks better. I would have preferred if you had removed the superfluous braces and else-branches as well. But it really is a matter of taste.
You might as well consider reducing the scope of the for-local variables (tol and a few more) by moving their definition inside the for loop.
Finally, a comment about the 4 magic defines A1..A4 would be nice.
|
@busstoptaktik, changes applied. I hope I got them all. |
|
Looks good to me - thanks for bothering with my nitpicks! |
|
@kbevers - I suppose you will want to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing missed @busstoptaktik's comment on previous pull request #1101.
@busstoptaktik please review the changes.