Disallow use of non-projection operations in proj (was: Don't convert non-angular inputs to proj to radians) #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Oct 26, 2018
kbevers
force-pushed
the
proj-output-units
branch
from
aae996a
to
04c0ab9
Compare
|
Thinking more about this, I am having doubts that this is the best solution. I am starting to lean towards |
kbevers
force-pushed
the
proj-output-units
branch
from
04c0ab9
to
44a5b16
Compare
kbevers
changed the title
|
I decided to change the logic so that |
kbevers
force-pushed
the
proj-output-units
branch
from
44a5b16
to
739377d
Compare
Since the introduction of other operations types than projections it has been unclear how proj should treat those. This commit sets record straight once and for all: proj is only allowed to initialize operations that take angular input and produces non-angular output, i.e. projections. This is true to the version of proj before the introduction of the pipeline and other non-projection operations. Users can still initiliaze pipelines with proj as long as the resulting concatenated operation requires angular input and outputs non-angular output.
kbevers
force-pushed
the
proj-output-units
branch
from
739377d
to
811ea08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on the mailing list, calling
projwith a operation that doesn't take angular input will not return the expected result. This is changed with this commit.