Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize CMake with cmakelint, 2-space indent #1330

Merged
merged 1 commit into from Mar 19, 2019
Merged

Conversation

mwtoews
Copy link
Member

@mwtoews mwtoews commented Mar 18, 2019

This PR does not change any functionality of CMake (or at least I hope not). It's intended to make these files more consistent, and using modern-ish CMake conventions. (This is only a small step towards #1263).

Most of these changes were found with cmakelint:

$ pip install cmakelint
$ git ls-files '*CMakeLists.txt' | xargs cmakelint
$ git ls-files '*.cmake' | xargs cmakelint

other changes are to try and use 2-space indents (this seem to be the norm), and spread file lists to 1-file-per-line, so possible changes are easier to see via diff.

@kbevers
Copy link
Member

kbevers commented Mar 19, 2019

Thanks Mike. It's nice to get some consistency!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants