Make sure that ISO19111 C++ code sets pj_errno on errors #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbevers
force-pushed
the
return_errno_proj_create
branch
from
c6c088b
to
6a41d46
Compare
kbevers
changed the title
kbevers
force-pushed
the
return_errno_proj_create
branch
from
6a41d46
to
20300c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on the mailing list,
proj_create()doesn't set the error number when an error is created. This also applies to many other functions insrc\iso19111\c_api.cpp. Fixed in this PR.I've added a new error code,
PJD_ERR_GENERIC_ERROR, which will be set if no other errno is applied when an exception is raised. This applies to all functions insrc\iso19111\c_api.cppthat callsproj_log_error()(which btw is badly named since it is not publicly accessible - should bepj_log_error()).