Add support for GEOIDMODEL #1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rouault
commented
Nov 2, 2019
rouault
commented
- WKT and PROJJSON: add import/export of geoid model of VertCRS
- Add a geoid_model name in database, use GEOIDMODEL for transformations, add a proj_create_vertical_crs_ex()
- Database: add mapping between EPSG geoid and PROJ grid names for GEOID99, 03, 06, 09 and 18. Related to Add USA geoid models 1999, 2003, 2006, 2009 and 2018 proj-datumgrid#60 that add those grids in proj-datumgrid-north-america
…s, add a proj_create_vertical_crs_ex()
…D99, 03, 06, 09 and 18. Related to OSGeo/proj-datumgrid#60 that add those grids in proj-datumgrid-north-america
…model in CRS name
kbevers
reviewed
Nov 4, 2019
kbevers
approved these changes
Nov 4, 2019
Member
kbevers
left a comment
kbevers
left a comment
There was a problem hiding this comment.
This is a lot to grasp but i believe it looks okay. I have added a few inlined comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.