DOC: fix the inclusion of the custom css file #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see if it works |
|
Artefact looks good, thanks @jorisvandenbossche ! |
|
Yeah, and I've backported it to 8.1 manually. Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mailing list message about broken css of proj.org. It seems that the readthedoc theme's css was no longer included in the
<head>(only the css overrides of proj itself). Might be triggered due to changes in sphinx_rtd_theme 1.0, which was just released, but didn't verify that.I think this patch fixes that (because sphinx puts the parent theme's css in
css_files, and thus the conf.py overrides this. And starting with sphinx_rtd_theme, it only relies on that readthedocs/sphinx_rtd_theme@836467e), and in any case it now includes the custom css as documented by rtd (https://docs.readthedocs.io/en/stable/guides/adding-custom-css.html)