add PJ_TYPE_DERIVED_PROJECTED_CRS #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjimenezshaw
commented
Nov 25, 2022
| @@ -803,6 +803,8 @@ typedef enum | |||
| PJ_TYPE_TEMPORAL_DATUM, | |||
| PJ_TYPE_ENGINEERING_DATUM, | |||
| PJ_TYPE_PARAMETRIC_DATUM, | |||
|
|
|||
| PJ_TYPE_DERIVED_PROJECTED_CRS, | |||
There was a problem hiding this comment.
I added it at the end of the enum for backward compatibility. If it is better anywhere else, let me know.
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Nov 25, 2022
…er 9.2.0dev OSGeo/PROJ#3488 added a PJ_TYPE_DERIVED_PROJECTED_CRS value to the PJ_TYPE enumeration that we didn't test obviously. But better just use proj_is_crs() to be more robust.
rouault
added a commit
to OSGeo/gdal
that referenced
this pull request
Nov 25, 2022
…er 9.2.0dev OSGeo/PROJ#3488 added a PJ_TYPE_DERIVED_PROJECTED_CRS value to the PJ_TYPE enumeration that we didn't test obviously. But better just use proj_is_crs() to be more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
PJ_TYPE proj_get_type(const PJ *obj)does not cover the case of aDerivedProjectedCRS, so it returns the generic typePJ_TYPE_OTHER_CRS. This PR defined the typePJ_TYPE_DERIVED_PROJECTED_CRS, and returns it in that case.