Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 9.4] Database: update to EPSG v11.006 #4086

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Mar 14, 2024

Backport of second commit of #4085

@rouault rouault added this to the 9.4.1 milestone Mar 14, 2024
@rouault
Copy link
Member Author

rouault commented Mar 16, 2024

The slight doubt I had about the appropriateness of the backport is that the WGS84 datum ensemble has gained a new datum realization with "World Geodetic System 1984 (G2296)", which thus changes the WKT2:2019 output of all EPSG:4326 based CRS. This could potentially break code (particular unit tests) that would do strict text comparison. But as far as GDAL is concerned, I didn't have tou change any unit tests (perhaps we already bit that bullet in the past with prior additions of new realizations so our tests are now robust to that)
Furthermore the isEquivalentTo() method considers CRS WKT definitions that only differ by differences in members of datum ensembles to be the same. And the identify() method also works with slightly different members in a datum ensemble provided it has the same name
So all in all, I believe it is reasonably safe for backport to stable branch.
CC @jjimenezshaw @kbevers

Copy link
Member

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to backport this

@rouault rouault merged commit ff8032d into OSGeo:9.4 Mar 16, 2024
23 checks passed
@imincik imincik mentioned this pull request Jun 3, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants