CI: switch from macos-latest to macos-13 to get x64 builds #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjimenezshaw
approved these changes
Apr 27, 2024
| @@ -22,7 +22,7 @@ jobs: | |||
| fail-fast: true | |||
| matrix: | |||
| include: | |||
| - platform: "macos-latest" | |||
| - platform: "macos-13" | |||
| architecture: "x64" | |||
| # macOS-14 is a M1 ARM64 MacOS runner: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ | |||
| - platform: "macOS-14" | |||
There was a problem hiding this comment.
Should we change this to latest? otherwise it is probable that we do not update to the newer ones.
There was a problem hiding this comment.
I don't know. The -latest is also a moving target that has switched between x64 and arm64, which is annoying. It is weird that they don't provide 2 separate keywords, one for the mac version and the other one for the architecture. But I believe Apple won't support x64 anymore, so perhaps at some point that will be arm64 only.
There was a problem hiding this comment.
Oh, yes. I think that the new models are all arm. The question is how long they will support the old ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA has changed the macos-latest alias to macos-14 (arm64), hence to get Intel Mac one now needs to explicitly select macos-13 Cf https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories