Fix warnings related to -Wshadow -Wnull-dereference -Wfloat-conversion -Wmissing-prototypes -Wmissing-declarations #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Feb 26, 2017
src/PJ_horner.c
Outdated
| @@ -451,6 +451,10 @@ PJ *PROJECTION(horner) { | |||
| complex_horner = 1; | |||
|
|
|||
| Q = horner_alloc (degree, complex_horner); | |||
| if( Q == 0 ) | |||
src/PJ_healpix.c
Outdated
| @@ -152,6 +152,7 @@ static int pnpoly(int nvert, double vert[][2], double testx, double testy) { | |||
| * @param north_square the position of the north polar square (rHEALPix only) | |||
| * @param south_square the position of the south polar square (rHEALPix only) | |||
| **/ | |||
| static | |||
There was a problem hiding this comment.
Why put these two on separate lines unlike the other ones added in this file?
src/PJ_robin.c
Outdated
| {0.6213, -0.010418, 8.83923e-05, 6.24051e-06}, | ||
| {0.5722, -0.00906601, 0.000182, 6.24051e-06}, | ||
| {0.5322, -0.00677797, 0.000275608, 6.24051e-06} | ||
| {1, 2.2199e-17f, -7.15515e-05f, 3.1103e-06f}, |
There was a problem hiding this comment.
Didn't change this 1 like the other below.
src/p_series.c
Outdated
|
|
||
| /* FIXME: put the declaration in a header. Also used in gen_cheb.c */ | ||
| void p_series(Tseries *T, FILE *file, char *fmt); | ||
|
|
||
| void |
There was a problem hiding this comment.
Maybe fix this extra indent like the other one, too?
src/rtodms.c
Outdated
| r = floor(r / 60.); | ||
| deg = r; | ||
| deg = (int)r; |
There was a problem hiding this comment.
What's up with the odd spacing here? Mixing tab and space?
…nr -Wmissing-prototypes -Wmissing-declarations
rouault
force-pushed
the
misc_warning_fixes
branch
7 times, most recently
from
3f25c4b
to
002f444
Compare
rouault
force-pushed
the
misc_warning_fixes
branch
from
002f444
to
a2303c2
Compare
…plicit conversions
rouault
force-pushed
the
misc_warning_fixes
branch
from
a2303c2
to
8eb46db
Compare
rouault
force-pushed
the
misc_warning_fixes
branch
from
93b6b06
to
abb21ad
Compare
c9f12e0. Issue raised by VS12
rouault
force-pushed
the
misc_warning_fixes
branch
4 times, most recently
from
c7ea684
to
b885fb6
Compare
rouault
force-pushed
the
misc_warning_fixes
branch
from
b885fb6
to
0cbb3c2
Compare
QuLogic
reviewed
Feb 27, 2017
| @@ -59,9 +60,13 @@ void* thread_main(void* unused) | |||
| int main(int argc, char* argv[]) | |||
There was a problem hiding this comment.
Could just be int main(void).
There was a problem hiding this comment.
Good point. Fixed in master now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.