Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run gie tests with CMake and autotools builds #705

Merged
merged 5 commits into from Jan 9, 2018
Merged

Run gie tests with CMake and autotools builds #705

merged 5 commits into from Jan 9, 2018

Conversation

kbevers
Copy link
Member

@kbevers kbevers commented Dec 11, 2017 •
edited

This adds the gie tests to the CMake and autotest testing facilities. GIGS tests have been converted from Python/json to gie and added as well. Note that some GIGS tests do not pass. The reason for this is described in #700. The failing tests are commented out for now.

Resolves #702.

@kbevers kbevers requested a review from rouault December 11, 2017 18:31
@kbevers kbevers force-pushed the gigs-gie-tests branch 7 times, most recently from d74cb8d to 2b90548 Compare December 12, 2017 07:17
@kbevers kbevers removed the request for review from rouault December 12, 2017 07:54
@kbevers
Copy link
Member Author

kbevers commented Dec 12, 2017 •
edited

@cffk I get this error from geodtest on some of the CI targets. I suspect it is a problem on 32 bit only. Is that a plausable assumption?

assertEquals fails: 180 != -180 +/- 5e-006
GeodSolve61 fail: 1

@kbevers kbevers mentioned this pull request Dec 18, 2017
Closed
@busstoptaktik
Copy link
Member

busstoptaktik commented Jan 3, 2018 •
edited

Is this ready for merging (modulo a few conflicts) with the corrections supplied by @cffk in #719? or is this a different problem?

@kbevers
Copy link
Member Author

kbevers commented Jan 3, 2018

Is this ready for merging (modulo a few conflicts) with the corrections supplied by @cffk in #719? or is this a different problem?

Nope. I need to restructure the travis setup in some way. At the moment coverage is run with the autotools build and I want to run it with the cmake build instead. Additionally I think too many builds are made (2 x autotools, 2 x CMake IIRC).

Frankly, I figured I'd look into this once the GIGS tests can be run properly with gie (requires #700 be resolved), but I can take a look at this tomorrow and see if I can get it ready to be merged without the GIGS tests.

@busstoptaktik
Copy link
Member

Don't worry, and don't hurry - I was just asking out of curiousity.

@kbevers
Add gie tests to autoconf makefile.
ef75825 
Download grid files as the first thing in the travis install script and
that 'make check' can be run without errors caused by missing grids.
@kbevers kbevers mentioned this pull request Jan 9, 2018
Merged
@kbevers kbevers changed the title Run gie tests with CMake Run gie tests with CMake and autotools builds Jan 9, 2018
@kbevers kbevers merged commit 12c502d into OSGeo:master Jan 9, 2018
@kbevers
Copy link
Member Author

kbevers commented Jan 9, 2018 •
edited

Merging before appveyor tests are run since this shouldn't affect Windows.

GIGS gie tests haven't been added to the test suites yet, but will be as soon as #700 is finished.

@kbevers kbevers deleted the gigs-gie-tests branch February 1, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kbevers @busstoptaktik