LIBKML: do not advertize RandomWrite capability (unless on a update l…

…ayer, when datasource is created with UPDATE_TARGETHREF creation option) (fixes qgis/QGIS#39087)
OSGeo · Sep 29, 2020 · a2166a9 · a2166a9
1 parent 9943ada
commit a2166a9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/autotest/ogr/ogr_libkml.py b/autotest/ogr/ogr_libkml.py
@@ -311,6 +311,9 @@ def ogr_libkml_write(filename):
         srs.SetWellKnownGeogCS('WGS72')
         lyr = ds.CreateLayer('test_wgs72', srs=srs)
 
+        assert lyr.TestCapability(ogr.OLCSequentialWrite) == 1
+        assert lyr.TestCapability(ogr.OLCRandomWrite) == 0
+
         dst_feat = ogr.Feature(lyr.GetLayerDefn())
         dst_feat.SetGeometry(ogr.CreateGeometryFromWkt('POINT (2 49)'))
         assert lyr.CreateFeature(dst_feat) == 0, 'CreateFeature failed.'
@@ -1376,10 +1379,11 @@ def test_ogr_libkml_write_update():
         with gdaltest.error_handler():
             lyr.CreateFeature(feat)
         feat.SetFID(10)
-        lyr.CreateFeature(feat)
+        assert lyr.CreateFeature(feat) == 0
         feat.SetFID(2)
-        lyr.SetFeature(feat)
-        lyr.DeleteFeature(3)
+        assert lyr.TestCapability(ogr.OLCRandomWrite) == 1
+        assert lyr.SetFeature(feat) == 0
+        assert lyr.DeleteFeature(3) == 0
         ds = None
 
         if i == 0:

diff --git a/gdal/ogr/ogrsf_frmts/libkml/ogrlibkmllayer.cpp b/gdal/ogr/ogrsf_frmts/libkml/ogrlibkmllayer.cpp
@@ -884,7 +884,7 @@ int OGRLIBKMLLayer::TestCapability( const char *pszCap )
     else if( EQUAL( pszCap, OLCSequentialWrite ) )
         result = bUpdate;
     else if( EQUAL( pszCap, OLCRandomWrite ) )
-        result = bUpdate;
+        result = bUpdate && m_poKmlUpdate != nullptr;
     else if( EQUAL( pszCap, OLCFastFeatureCount ) )
         result = FALSE;
     else if( EQUAL( pszCap, OLCFastSetNextByIndex ) )