Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal zlib copy #5587

Closed
rouault opened this issue Apr 7, 2022 · 3 comments
Closed

Update internal zlib copy #5587

rouault opened this issue Apr 7, 2022 · 3 comments

Comments

@rouault
Copy link
Member

rouault commented Apr 7, 2022

It is a version 1.2.3 and CVE-2018-25032 affects zlib < 1.2.12
@jmckenna
Copy link
Contributor

jmckenna commented Apr 7, 2022

Could we make zlib be a required external dependency? (I agree, the embedded zlib causes so much problems in GDAL)

@jmckenna
Copy link
Contributor

jmckenna commented Apr 7, 2022 •
edited

To be more precise: the embedded zlib causes problems for those leveraging GDAL downstream.

@rouault
Copy link
Member Author

rouault commented Apr 7, 2022

the embedded zlib causes problems for those leveraging GDAL downstream.

in master, when using CMake builds, the symbols of the embedded zlib are now prefixed with gdal_, which should avoid clashes when using GDAL with other software that links external zlib.

@rouault rouault closed this as completed in a3d51f6 Apr 7, 2022
rouault added a commit that referenced this issue Apr 7, 2022
@rouault
Merge pull request #5588 from rouault/fix_5587
f5fa616 
Internal zlib: update to 1.2.12 (fixes #5587)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rouault @jmckenna