Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu/Dockerfile: fix rm & remove apt lists #10254

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

pjonsson
Copy link
Contributor

What does this PR do?

Fix the rm command near the top of the Dockerfile for the Ubuntu images, remove apt lists to reduce size of image, and pass --no-install-recommends when installing patchelf to avoid surprise packages in the future.

What are related issues/pull requests?

Tasklist

  • ADD YOUR TASKS HERE
  • Make sure code is correctly formatted (cf pre-commit configuration)
  • Add test case(s)
  • Add documentation
  • Updated Python API documentation (swig/include/python/docs/)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS:
  • Compiler:

There seems to be a missing &&,
but join the two lines into a single
rm invocation instead.
The apt lists are sizable, so remove
them from the image.
Add --no-install-recommends to avoid
extra surprise packages in the future.
@rouault rouault merged commit 6a803e6 into OSGeo:master Jun 20, 2024
33 checks passed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.578% (+0.3%) from 69.244%
when pulling adc81b5 on pjonsson:dockerfile-rm-right
into 90d38f5 on OSGeo:master.

@pjonsson pjonsson deleted the dockerfile-rm-right branch June 21, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants