Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ogr dxf driver spline entity reading (ticket #6436) #115

Closed
wants to merge 5 commits into from
Closed

Improve ogr dxf driver spline entity reading (ticket #6436) #115

wants to merge 5 commits into from

Conversation

perob
Copy link

@perob perob commented Apr 3, 2016

Changed source code and added tests with data.

Read full definition of spline entity (degree, control points, weights and knots) from dxf files and create spline. If only degree and control points found in dxf file then recalculate knots. Weights are always 1 if not present in dxf file.

@perob perob changed the title Improve ogr dxf drive spline entity reading (ticket #6436) Improve ogr dxf driver spline entity reading (ticket #6436) Apr 3, 2016
@rouault
Copy link
Member

rouault commented Apr 3, 2016

The Travis build errors with :

  TEST: ogr_dxf_30 ... OGRFeature(entities):1
  Layer (String) = 0
  SubClasses (String) = AcDbEntity:AcDbSpline
  ExtendedEntity (String) = (null)
  Linetype (String) = (null)
  EntityHandle (String) = 24C
  Text (String) = (null)
  LINESTRING (0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,0 0,14 2)

fail
    line 123: Error in vertex 0, off by 14.

@perob
Copy link
Author

perob commented Apr 3, 2016

Ah, thanks.
I created test files manually and obviously made some mistakes which passed through sanity checks.

I will add some more sanity checks.

@perob
Copy link
Author

perob commented Apr 4, 2016

That is it. Ready for commit.

@rouault
Copy link
Member

rouault commented Apr 4, 2016

Merged in r33888. Thanks

@rouault rouault closed this Apr 4, 2016
kwrobot pushed a commit to aashish24/gdal-svn that referenced this pull request Apr 4, 2016
…rol points, weights and knots) when stroking splines (patch by Pero Brbora, #6436, OSGeo/gdal#115)

git-svn-id: https://svn.osgeo.org/gdal/trunk/gdal@33888 f0d54148-0727-0410-94bb-9a71ac55c965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants